Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(685)

Issue 5335048: code review 5335048: net: renamings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by r
Modified:
13 years, 4 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

net: renamings This is Go 1 package renaming CL #3. This one merely moves the source; the import strings will be changed after the next weekly release. This one moves pieces into net. http -> net/http http/cgi -> net/http/cgi http/fcgi -> net/http/fcgi http/pprof -> net/http/pprof http/httptest -> net/http/httptest mail -> net/mail rpc -> net/rpc rpc/jsonrpc -> net/rpc/jsonrpc smtp -> net/smtp url -> net/url Also remove rand (now math/rand) from NOTEST - it has a test. The only edits are in Makefiles and deps.bash.

Patch Set 1 #

Patch Set 2 : diff -r 191305afc6c9 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-16 lines, --34 lines) Patch
M src/pkg/Makefile View 6 chunks +12 lines, -13 lines 0 comments Download
M src/pkg/deps.bash View 2 chunks +19 lines, -0 lines 0 comments Download
M src/pkg/net/http/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/net/http/cgi/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/net/http/cgi/child.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/cgi/child_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/cgi/host.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/cgi/host_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/cgi/matryoshka_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/cgi/testdata/test.cgi View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/chunked.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/client.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/client_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/cookie.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/cookie_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/doc.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/dump.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/export_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/fcgi/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/net/http/fcgi/child.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/fcgi/fcgi.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/fcgi/fcgi_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/filetransport.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/filetransport_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/fs.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/fs_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/header.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/header_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/httptest/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/net/http/httptest/recorder.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/httptest/server.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/lex.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/lex_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/persist.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/pprof/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/net/http/pprof/pprof.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/proxy_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/range_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/readrequest_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/request.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/request_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/requestwrite_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/response.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/response_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/responsewrite_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/reverseproxy.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/reverseproxy_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/serve_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/server.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/sniff.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/sniff_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/status.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/testdata/file View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/testdata/index.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/testdata/style.css View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/transfer.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/transport.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/transport_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/transport_windows.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/http/triv.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/mail/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/net/mail/message.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/mail/message_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/rpc/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/net/rpc/client.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/rpc/debug.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/rpc/jsonrpc/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/net/rpc/jsonrpc/all_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/rpc/jsonrpc/client.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/rpc/jsonrpc/server.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/rpc/server.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/rpc/server_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/smtp/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/net/smtp/auth.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/smtp/smtp.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/smtp/smtp_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/url/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/net/url/url.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/net/url/url_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2011-11-03 20:04:58 UTC) #1
bradfitz
LGTM On Thu, Nov 3, 2011 at 1:04 PM, <r@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
13 years, 4 months ago (2011-11-03 20:23:20 UTC) #2
r
13 years, 4 months ago (2011-11-03 20:26:51 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=f5b1cf2c3320 ***

net: renamings
This is Go 1 package renaming CL #3.
This one merely moves the source; the import strings will be
changed after the next weekly release.
This one moves pieces into net.

http -> net/http
http/cgi -> net/http/cgi
http/fcgi -> net/http/fcgi
http/pprof -> net/http/pprof
http/httptest -> net/http/httptest
mail -> net/mail
rpc -> net/rpc
rpc/jsonrpc -> net/rpc/jsonrpc
smtp -> net/smtp
url -> net/url

Also remove rand (now math/rand) from NOTEST - it has a test.

The only edits are in Makefiles and deps.bash.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5335048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b