Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11)

Issue 5333049: code review 5333049: gc: test + fix escape analysis bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by rsc
Modified:
10 years, 9 months ago
Reviewers:
CC:
lvd, golang-dev
Visibility:
Public.

Description

gc: test + fix escape analysis bug

Patch Set 1 #

Patch Set 2 : diff -r db6289ea7a02 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r db6289ea7a02 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 64a7c82147a0 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -70 lines) Patch
M src/cmd/gc/esc.c View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M test/escape2.go View 1 2 3 29 chunks +88 lines, -70 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello lvd (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 9 months ago (2011-10-31 20:35:47 UTC) #1
lvd
LGTM http://codereview.appspot.com/5333049/diff/4001/src/cmd/gc/esc.c File src/cmd/gc/esc.c (right): http://codereview.appspot.com/5333049/diff/4001/src/cmd/gc/esc.c#newcode244 src/cmd/gc/esc.c:244: escassign(&theSink, n->left->right); // ODDDARG for call if you ...
10 years, 9 months ago (2011-11-01 08:36:59 UTC) #2
rsc
10 years, 9 months ago (2011-11-01 15:02:49 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=d95e373abf55 ***

gc: test + fix escape analysis bug

R=lvd
CC=golang-dev
http://codereview.appspot.com/5333049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b