Issue 5333049: code review 5333049: gc: test + fix escape analysis bug

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5333049: code review 5333049: gc: test + fix escape analysis bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by rsc

Modified:
12 years, 5 months ago

Reviewers:

CC:
lvd, golang-dev

Visibility:
Public.

Patch Set 2 : diff -r db6289ea7a02 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r db6289ea7a02 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 64a7c82147a0 https://go.googlecode.com/hg/ #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -70 lines)			Patch
	M	src/cmd/gc/esc.c	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
	M	test/escape2.go	View	1 2 3	29 chunks	+88 lines, -70 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello lvd (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 5 months ago (2011-10-31 20:35:47 UTC) #1

lvd

LGTM http://codereview.appspot.com/5333049/diff/4001/src/cmd/gc/esc.c File src/cmd/gc/esc.c (right): http://codereview.appspot.com/5333049/diff/4001/src/cmd/gc/esc.c#newcode244 src/cmd/gc/esc.c:244: escassign(&theSink, n->left->right); // ODDDARG for call if you ...

12 years, 5 months ago (2011-11-01 08:36:59 UTC) #2

rsc

12 years, 5 months ago (2011-11-01 15:02:49 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=d95e373abf55 ***

gc: test + fix escape analysis bug

R=lvd
CC=golang-dev
http://codereview.appspot.com/5333049

Expand All Messages | Collapse All Messages