Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 5332053: code review 5332053: html,log,math: renamings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by r
Modified:
13 years, 4 months ago
Reviewers:
CC:
r2, rsc, golang-dev
Visibility:
Public.

Description

html,log,math: renamings This is Go 1 package renaming CL #2. This one merely moves the source; the import strings will be changed after the next weekly release. exp/template/html -> html/template big -> math/big cmath -> math/cmplx rand -> math/rand syslog -> log/syslog The only edits are in Makefiles and deps.bash. Note that this CL moves exp/template/html out of exp. I decided to do that so all the renamings can be done together, even though the API (and that of template, for that matter) is still fluid.

Patch Set 1 #

Patch Set 2 : diff -r cdf4e4406ff6 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r cdf4e4406ff6 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9d2976cf80fc https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-27 lines, --37 lines) Patch
M src/pkg/Makefile View 6 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/deps.bash View 1 2 2 chunks +15 lines, -5 lines 0 comments Download
M src/pkg/html/template/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/html/template/attr.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/clone.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/clone_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/content.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/content_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/context.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/css.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/css_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/doc.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/error.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/escape.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/escape_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/html.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/html_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/js.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/js_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/transition.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/url.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/html/template/url_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/log/syslog/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/log/syslog/syslog.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/log/syslog/syslog_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/log/syslog/syslog_unix.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/big/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/math/big/arith.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/big/arith_386.s View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/big/arith_amd64.s View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/big/arith_arm.s View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/big/arith_decl.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/big/arith_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/big/calibrate_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/big/hilbert_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/big/int.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/big/int_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/big/nat.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/big/nat_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/big/rat.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/big/rat_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/cmplx/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/math/cmplx/abs.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/cmplx/asin.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/cmplx/cmath_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/cmplx/conj.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/cmplx/exp.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/cmplx/isinf.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/cmplx/isnan.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/cmplx/log.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/cmplx/phase.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/cmplx/polar.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/cmplx/pow.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/cmplx/rect.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/cmplx/sin.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/cmplx/sqrt.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/cmplx/tan.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/rand/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/math/rand/exp.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/rand/normal.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/rand/rand.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/rand/rand_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/rand/rng.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/math/rand/zipf.go View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2011-11-03 18:54:33 UTC) #1
r2
fixed the CL description to say Go 1 sted Go 2
13 years, 4 months ago (2011-11-03 19:06:11 UTC) #2
rsc
LGTM assuming you need an hg sync + convert makefile
13 years, 4 months ago (2011-11-03 19:27:11 UTC) #3
r2
waiting for the windows build to go green before updating
13 years, 4 months ago (2011-11-03 19:27:44 UTC) #4
r
Hello r@google.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 4 months ago (2011-11-03 19:37:13 UTC) #5
rsc
LGTM
13 years, 4 months ago (2011-11-03 19:38:16 UTC) #6
r
13 years, 4 months ago (2011-11-03 19:43:06 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=191305afc6c9 ***

html,log,math: renamings
This is Go 1 package renaming CL #2.
This one merely moves the source; the import strings will be
changed after the next weekly release.

exp/template/html -> html/template
big -> math/big
cmath -> math/cmplx
rand -> math/rand
syslog -> log/syslog

The only edits are in Makefiles and deps.bash.

Note that this CL moves exp/template/html out of exp. I decided
to do that so all the renamings can be done together, even though
the API (and that of template, for that matter) is still fluid.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/5332053
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b