Issue 5332051: code review 5332051: gc, ld: sync pathtoprefix + add comments

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5332051: code review 5332051: gc, ld: sync pathtoprefix + add comments (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by rsc

Modified:
13 years, 4 months ago

Reviewers:

CC:
lvd, golang-dev

Visibility:
Public.

Description

gc, ld: sync pathtoprefix + add comments

Patch Set 1 #

Patch Set 2 : diff -r 742fd8d238fd https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	src/cmd/gc/subr.c	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/cmd/ld/lib.c	View		2 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello lvd (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-11-03 16:44:32 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=2326dbb31485 *** gc, ld: sync pathtoprefix + add comments R=lvd, lvd CC=golang-dev ...

13 years, 4 months ago (2011-11-03 16:44:55 UTC) #2

lvd

13 years, 4 months ago (2011-11-03 16:48:27 UTC) #3

LSBTMTMOO
/L

On Thu, Nov 3, 2011 at 17:44, <rsc@golang.org> wrote:

> *** Submitted as
>
http://code.google.com/p/go/**source/detail?r=2326dbb31485<http://code.google...
>
>
> gc, ld: sync pathtoprefix + add comments
>
> R=lvd, lvd
> CC=golang-dev
> http://codereview.appspot.com/**5332051<http://codereview.appspot.com/5332051>
>
>
>
http://codereview.appspot.com/**5332051/<http://codereview.appspot.com/5332051/>
>

Expand All Messages | Collapse All Messages