Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(346)

Issue 5331066: code review 5331066: os,text,unicode: renamings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by r
Modified:
13 years, 4 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

os,text,unicode: renamings This is Go 1 package renaming CL #4. This one merely moves the source; the import strings will be changed after the next weekly release. This one moves pieces into os, text, and unicode. exec -> os/exec scanner -> text/scanner tabwriter -> text/tabwriter template -> text/template template/parse -> text/template/parse utf16 -> unicode/utf16 utf8 -> unicode/utf8 This should be the last of the source-rearranging CLs.

Patch Set 1 #

Patch Set 2 : diff -r a4edf9075b51 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, --13 lines) Patch
M src/pkg/Makefile View 3 chunks +7 lines, -7 lines 0 comments Download
M src/pkg/deps.bash View 4 chunks +14 lines, -0 lines 0 comments Download
M src/pkg/os/exec/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/os/exec/exec.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/os/exec/exec_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/os/exec/lp_plan9.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/os/exec/lp_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/os/exec/lp_unix.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/os/exec/lp_windows.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/scanner/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/text/scanner/scanner.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/scanner/scanner_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/tabwriter/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/text/tabwriter/tabwriter.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/tabwriter/tabwriter_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/text/template/doc.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/exec.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/exec_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/funcs.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/helper.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/parse.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/parse/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/text/template/parse/lex.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/parse/lex_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/parse/node.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/parse/parse.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/parse/parse_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/parse/set.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/set.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/set_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/testdata/file1.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/testdata/file2.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/testdata/tmpl1.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/text/template/testdata/tmpl2.tmpl View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/unicode/utf16/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/unicode/utf16/utf16.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/unicode/utf16/utf16_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/unicode/utf8/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/unicode/utf8/string.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/unicode/utf8/string_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/unicode/utf8/utf8.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/unicode/utf8/utf8_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2011-11-03 20:44:18 UTC) #1
rsc
LGTM
13 years, 4 months ago (2011-11-03 21:15:21 UTC) #2
r
13 years, 4 months ago (2011-11-03 21:18:12 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=d878b6a5a788 ***

os,text,unicode: renamings
This is Go 1 package renaming CL #4.
This one merely moves the source; the import strings will be
changed after the next weekly release.
This one moves pieces into os, text, and unicode.

exec -> os/exec
scanner -> text/scanner
tabwriter -> text/tabwriter
template -> text/template
template/parse -> text/template/parse
utf16 -> unicode/utf16
utf8 -> unicode/utf8

This should be the last of the source-rearranging CLs.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5331066
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b