Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1306)

Issue 5331060: code review 5331060: encoding: move asn1, csv, gob, json, xml into encoding (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by r
Modified:
13 years, 4 months ago
Reviewers:
CC:
r2, rsc, golang-dev
Visibility:
Public.

Description

encoding: move asn1, csv, gob, json, xml into encoding This is Go 1 package renaming CL #1. This one merely moves the source; the import strings will be changed after the next weekly release. The only edits are in Makefiles.

Patch Set 1 #

Patch Set 2 : diff -r e6a7e56f806b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e1e97028a407 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-6 lines, --26 lines) Patch
M src/pkg/Makefile View 1 6 chunks +8 lines, -5 lines 0 comments Download
M src/pkg/deps.bash View 1 2 2 chunks +19 lines, -2 lines 0 comments Download
M src/pkg/encoding/asn1/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/encoding/asn1/asn1.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/asn1/asn1_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/asn1/common.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/asn1/marshal.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/asn1/marshal_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/csv/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/encoding/csv/reader.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/csv/reader_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/csv/writer.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/csv/writer_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/gob/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/encoding/gob/codec_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/gob/debug.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/gob/decode.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/gob/decoder.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/gob/doc.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/gob/dump.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/gob/encode.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/gob/encoder.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/gob/encoder_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/gob/error.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/gob/gobencdec_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/gob/timing_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/gob/type.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/gob/type_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/json/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/encoding/json/decode.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/json/decode_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/json/encode.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/json/encode_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/json/indent.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/json/scanner.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/json/scanner_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/json/stream.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/json/stream_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/json/tagkey_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/json/tags.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/json/tags_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/xml/Makefile View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/encoding/xml/atom_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/xml/embed_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/xml/marshal.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/xml/marshal_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/xml/read.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/xml/read_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/xml/xml.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/pkg/encoding/xml/xml_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2011-11-02 23:27:51 UTC) #1
r2
hold on, need to fix deps too
13 years, 4 months ago (2011-11-02 23:38:39 UTC) #2
r
Hello golang-dev@googlegroups.com, r@google.com (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 4 months ago (2011-11-03 00:41:03 UTC) #3
r2
deps.bash hacked now.
13 years, 4 months ago (2011-11-03 00:41:41 UTC) #4
rsc
LGTM
13 years, 4 months ago (2011-11-03 12:17:27 UTC) #5
r
13 years, 4 months ago (2011-11-03 18:40:00 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=5302f0085955 ***

encoding: move asn1, csv, gob, json, xml into encoding
This is Go 1 package renaming CL #1.
This one merely moves the source; the import strings will be
changed after the next weekly release.

The only edits are in Makefiles.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/5331060
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b