Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1446)

Issue 5323062: Fixes NoteColumn vs SpanBar collisions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by MikeSol
Modified:
7 years, 9 months ago
Reviewers:
mike, Keith, pkx166h, wl, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fixes NoteColumn vs SpanBar collisions.

Patch Set 1 #

Patch Set 2 : Fixes texidoc in span-bar-spacing.ly #

Patch Set 3 : Assures correct horizontal space for prefatory and loose columns. #

Patch Set 4 : Brings TimeSignature extra-spacing-height to span StaffSymbol #

Total comments: 3

Patch Set 5 : Incorporates Keith's suggestions. #

Patch Set 6 : Incorporates Keith's suggestions. #

Total comments: 2

Patch Set 7 : Fixes grace note spacing problem. #

Total comments: 6

Patch Set 8 : Makes function in the pure-from-neighbor-interface easier to read. #

Patch Set 9 : Allows grobs to be selective about their neighbors. #

Patch Set 10 : Close to pure nirvana. #

Total comments: 2

Patch Set 11 : Gets rid of useless property. #

Patch Set 12 : Fixes variable naming and a function in the pure-from-neighbor interface. #

Total comments: 10

Patch Set 13 : Incorporates more useful comments, deletes misleading ones. #

Patch Set 14 : Uber-patch that can be pushed as separate commits. #

Patch Set 15 : Adds pure-from-neighbor-interface to key signatures #

Patch Set 16 : Compiles cleanly on master. #

Patch Set 17 : First step - fixing span bar collisions. #

Total comments: 2

Patch Set 18 : Incorporates Keith's suggestonis. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -62 lines) Patch
M input/regression/span-bar-spacing.ly View 1 1 chunk +7 lines, -2 lines 0 comments Download
M lily/axis-group-interface.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +6 lines, -1 line 0 comments Download
M lily/bar-line.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/axis-group-interface.hh View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/pure-from-neighbor-interface.hh View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M lily/include/span-bar.hh View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M lily/pure-from-neighbor-engraver.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +54 lines, -25 lines 0 comments Download
M lily/pure-from-neighbor-interface.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +23 lines, -18 lines 0 comments Download
M lily/span-bar.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +12 lines, -0 lines 0 comments Download
M lily/span-bar-engraver.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M lily/span-bar-stub-engraver.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +7 lines, -3 lines 0 comments Download
M lily/staff-symbol-referencer-scheme.cc View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M ly/engraver-init.ly View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 4 chunks +4 lines, -2 lines 0 comments Download
M scm/define-grobs.scm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 14 chunks +28 lines, -6 lines 0 comments Download
M scm/output-lib.scm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +34 lines, -3 lines 0 comments Download

Messages

Total messages: 50
MikeSol
Hey all, This fixes the SpanBar regression ID'd by Phil. It also fixes a few ...
7 years, 10 months ago (2011-10-31 09:08:05 UTC) #1
wl_gnu.org
> This fixes the SpanBar regression ID'd by Phil. Thanks for working on this. Ideally, ...
7 years, 10 months ago (2011-10-31 10:15:29 UTC) #2
mike_apollinemike.com
On Oct 31, 2011, at 11:12 AM, Werner LEMBERG wrote: > >> This fixes the ...
7 years, 10 months ago (2011-10-31 11:27:40 UTC) #3
wl_gnu.org
>> Ideally, this should be another three different commits. > > The fixes are offshoots ...
7 years, 10 months ago (2011-10-31 12:30:37 UTC) #4
mail_philholmes.net
----- Original Message ----- From: <mtsolo@gmail.com> To: <mtsolo@gmail.com> Cc: <reply@codereview.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Monday, October 31, ...
7 years, 10 months ago (2011-10-31 14:20:01 UTC) #5
mike_apollinemike.com
On Oct 31, 2011, at 3:19 PM, Phil Holmes wrote: > > Mike - do ...
7 years, 10 months ago (2011-10-31 17:18:53 UTC) #6
mike_apollinemike.com
On Oct 31, 2011, at 6:18 PM, mike@apollinemike.com wrote: > On Oct 31, 2011, at ...
7 years, 10 months ago (2011-11-01 08:25:48 UTC) #7
dak
On 2011/11/01 08:25:48, mike_apollinemike.com wrote: > Given that the 0.6 skyline horizontal padding is, > ...
7 years, 10 months ago (2011-11-01 08:44:16 UTC) #8
mike_apollinemike.com
On Nov 1, 2011, at 9:44 AM, dak@gnu.org wrote: > On 2011/11/01 08:25:48, mike_apollinemike.com wrote: ...
7 years, 10 months ago (2011-11-01 09:36:27 UTC) #9
pkx166h
Passes Make but lots of reg test diffs here: http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-td4962666.html James
7 years, 10 months ago (2011-11-03 23:31:11 UTC) #10
Keith
I'll try to make a patch so that note-spacing is not affected by potential collisions ...
7 years, 10 months ago (2011-11-04 06:39:56 UTC) #11
mike_apollinemike.com
On Nov 3, 2011, at 11:39 PM, k-ohara5a5a@oco.net wrote: > I'll try to make a ...
7 years, 10 months ago (2011-11-04 07:12:11 UTC) #12
dak
"mike@apollinemike.com" <mike@apollinemike.com> writes: > On Nov 3, 2011, at 11:39 PM, k-ohara5a5a@oco.net wrote: > >> ...
7 years, 10 months ago (2011-11-04 08:03:37 UTC) #13
mike_apollinemike.com
On Nov 4, 2011, at 1:02 AM, David Kastrup wrote: > "mike@apollinemike.com" <mike@apollinemike.com> writes: > ...
7 years, 10 months ago (2011-11-04 13:44:59 UTC) #14
mike_apollinemike.com
On Nov 4, 2011, at 1:52 AM, Keith OHara wrote: > On Fri, 04 Nov ...
7 years, 10 months ago (2011-11-04 16:47:25 UTC) #15
mike_apollinemike.com
On Nov 4, 2011, at 1:00 PM, Keith OHara wrote: > On Fri, 04 Nov ...
7 years, 10 months ago (2011-11-04 21:03:05 UTC) #16
pkx166h
Passes Make but lots of reg test diffs http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-td4962666.html James
7 years, 10 months ago (2011-11-04 22:25:09 UTC) #17
mike_apollinemike.com
On Nov 4, 2011, at 2:35 PM, Keith OHara wrote: > The bug happens when ...
7 years, 10 months ago (2011-11-05 11:20:05 UTC) #18
Keith
> >> Pure relevant is used all over the code. > > > > Good ...
7 years, 10 months ago (2011-11-05 23:11:45 UTC) #19
mike_apollinemike.com
On Nov 5, 2011, at 4:11 PM, k-ohara5a5a@oco.net wrote: > http://codereview.appspot.com/5323062/diff/29001/lily/pure-from-neighbor-engraver.cc#newcode49 > lily/pure-from-neighbor-engraver.cc:49: SCM pure_relevant_p ...
7 years, 10 months ago (2011-11-06 01:04:56 UTC) #20
pkx166h
passes make, lots of reg test diffs here http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-td4962666.html James
7 years, 10 months ago (2011-11-06 09:25:39 UTC) #21
Keith
Until someone comes along who understands this, I'll display my confusions. http://codereview.appspot.com/5323062/diff/28002/lily/pure-from-neighbor-interface.cc File lily/pure-from-neighbor-interface.cc (right): ...
7 years, 10 months ago (2011-11-07 01:25:30 UTC) #22
MikeSol
http://codereview.appspot.com/5323062/diff/28002/lily/pure-from-neighbor-interface.cc File lily/pure-from-neighbor-interface.cc (right): http://codereview.appspot.com/5323062/diff/28002/lily/pure-from-neighbor-interface.cc#newcode84 lily/pure-from-neighbor-interface.cc:84: // uses drul array for grace (LEFT) vs. not ...
7 years, 10 months ago (2011-11-07 07:34:37 UTC) #23
mike_apollinemike.com
On Nov 7, 2011, at 10:46 AM, Keith OHara wrote: > >> This is saying ...
7 years, 10 months ago (2011-11-07 19:36:22 UTC) #24
pkx166h
Passes make but lots of reg test diffs as usual http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-7-Nov-2011-td4962666.html Jame
7 years, 10 months ago (2011-11-07 21:03:49 UTC) #25
mike_apollinemike.com
On Nov 7, 2011, at 8:19 PM, Keith OHara wrote: > Mike, > Now that ...
7 years, 10 months ago (2011-11-08 04:51:20 UTC) #26
mike_apollinemike.com
On Nov 7, 2011, at 9:33 PM, Keith OHara wrote: > On Mon, 07 Nov ...
7 years, 10 months ago (2011-11-08 12:21:01 UTC) #27
mike_apollinemike.com
On Nov 8, 2011, at 4:20 AM, mike@apollinemike.com wrote: > On Nov 7, 2011, at ...
7 years, 10 months ago (2011-11-08 16:01:49 UTC) #28
pkx166h
Passes make and all reg test diffs here: http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-8-Nov-2011-td4962666.html james
7 years, 10 months ago (2011-11-08 21:00:07 UTC) #29
dak
"mike@apollinemike.com" <mike@apollinemike.com> writes: > example. I've attached two versions of: > > \relative c'''' { ...
7 years, 10 months ago (2011-11-08 21:50:56 UTC) #30
Keith
http://codereview.appspot.com/5323062/diff/39005/lily/pure-from-neighbor-engraver.cc File lily/pure-from-neighbor-engraver.cc (right): http://codereview.appspot.com/5323062/diff/39005/lily/pure-from-neighbor-engraver.cc#newcode60 lily/pure-from-neighbor-engraver.cc:60: pure_relevants_.push_back (i.item ()); It seems that pure_relevants_[] are the ...
7 years, 10 months ago (2011-11-09 06:16:50 UTC) #31
mike_apollinemike.com
On Nov 8, 2011, at 10:16 PM, k-ohara5a5a@oco.net wrote: > > http://codereview.appspot.com/5323062/diff/39005/lily/pure-from-neighbor-engraver.cc > File lily/pure-from-neighbor-engraver.cc ...
7 years, 10 months ago (2011-11-09 14:55:52 UTC) #32
pkx166h
passes make and reg test diffs are all here: http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-9-Nov-2011-td4962666.html James
7 years, 10 months ago (2011-11-09 20:48:15 UTC) #33
Keith
http://codereview.appspot.com/5323062/diff/53017/lily/pure-from-neighbor-engraver.cc File lily/pure-from-neighbor-engraver.cc (right): http://codereview.appspot.com/5323062/diff/53017/lily/pure-from-neighbor-engraver.cc#newcode72 lily/pure-from-neighbor-engraver.cc:72: //first, clump pure_relevants into vectors of grobs that have ...
7 years, 10 months ago (2011-11-10 07:04:55 UTC) #34
MikeSol
As always, many thanks for your comments! http://codereview.appspot.com/5323062/diff/53017/lily/pure-from-neighbor-engraver.cc File lily/pure-from-neighbor-engraver.cc (right): http://codereview.appspot.com/5323062/diff/53017/lily/pure-from-neighbor-engraver.cc#newcode72 lily/pure-from-neighbor-engraver.cc:72: //first, clump ...
7 years, 10 months ago (2011-11-10 14:51:22 UTC) #35
Keith
On 2011/11/10 14:51:22, MikeSol wrote: >> If we know the space allocated to a staff ...
7 years, 10 months ago (2011-11-10 18:38:30 UTC) #36
mike_apollinemike.com
On Nov 10, 2011, at 10:38 AM, k-ohara5a5a@oco.net wrote: > On 2011/11/10 14:51:22, MikeSol wrote: ...
7 years, 10 months ago (2011-11-10 18:49:48 UTC) #37
pkx166h
passes make and reg tests all posted here: http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-reg-test-diffs-10-Nov-2011-td4962666.html James
7 years, 10 months ago (2011-11-10 19:53:57 UTC) #38
mike_apollinemike.com
On Nov 10, 2011, at 7:49 PM, mike@apollinemike.com wrote: > On Nov 10, 2011, at ...
7 years, 10 months ago (2011-11-11 15:34:42 UTC) #39
pkx166h
Mike, On Fri, Nov 11, 2011 at 3:34 PM, mike@apollinemike.com <mike@apollinemike.com> wrote: > ... > ...
7 years, 10 months ago (2011-11-11 15:44:06 UTC) #40
mike_apollinemike.com
On Nov 11, 2011, at 4:44 PM, Peekay Ex wrote: > Mike, > > On ...
7 years, 10 months ago (2011-11-11 15:56:07 UTC) #41
pkx166h
Mike, On Fri, Nov 11, 2011 at 3:55 PM, mike@apollinemike.com <mike@apollinemike.com> wrote: > On Nov ...
7 years, 10 months ago (2011-11-11 16:22:53 UTC) #42
mike_apollinemike.com
On Nov 11, 2011, at 5:22 PM, Peekay Ex wrote: > > Thanks, so just ...
7 years, 10 months ago (2011-11-11 16:39:07 UTC) #43
pkx166h
Doesn't pass make --snip-- [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/lily-sort.scm] [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-functions.scm] [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-translation.scm] [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-music.scm] [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-type-predicates.scm] [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-identifiers.scm] [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-context-mods.scm] [/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-backend.scm fatal error: define-grob-properties.scm: ...
7 years, 10 months ago (2011-11-11 18:17:46 UTC) #44
pkx166h
Passes Make and reg tests are all here http://lilypond-stuff.1065243.n5.nabble.com/Tracker-issue-2000-12-November-td4986583.html James
7 years, 10 months ago (2011-11-12 09:13:12 UTC) #45
pkx166h
Passes make and reg tests are here http://code.google.com/p/lilypond/issues/detail?id=2000#c32 James
7 years, 10 months ago (2011-11-20 17:28:24 UTC) #46
Keith
Looks okay to me. The ghost of the SpanBar (left over from the issue 910 ...
7 years, 10 months ago (2011-11-21 07:06:53 UTC) #47
mike_apollinemike.com
On Mon, 21 Nov 2011 07:06:53 +0000, k-ohara5a5a@oco.net wrote: > Looks okay to me. > ...
7 years, 10 months ago (2011-11-21 07:57:29 UTC) #48
Keith
On Sun, 20 Nov 2011 23:57:22 -0800, <mike@apollinemike.com> wrote: > On Mon, 21 Nov 2011 ...
7 years, 10 months ago (2011-11-21 08:16:15 UTC) #49
pkx166h
7 years, 10 months ago (2011-11-21 16:47:39 UTC) #50
passes make and no reg tests show up.

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b