Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(698)

Issue 5322067: code review 5322067: builtin: document the basic types (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by r
Modified:
7 years ago
Reviewers:
CC:
bradfitz, r2, niemeyer, rsc, golang-dev
Visibility:
Public.

Description

builtin: document the basic types The recursive definitions are illegal Go, but godoc doesn't mind.

Patch Set 1 #

Patch Set 2 : diff -r b3385d4cb197 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b3385d4cb197 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 4 : diff -r b3385d4cb197 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 5 : diff -r b3385d4cb197 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 6 : diff -r b3385d4cb197 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 7 : diff -r b3385d4cb197 https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r b3385d4cb197 https://go.googlecode.com/hg/ #

Patch Set 9 : diff -r b3385d4cb197 https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 10 : diff -r 1cf0ffaa8490 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -2 lines) Patch
M src/pkg/builtin/builtin.go View 1 2 3 4 5 6 7 8 9 2 chunks +78 lines, -2 lines 0 comments Download

Messages

Total messages: 15
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
7 years ago (2011-11-02 18:16:46 UTC) #1
r
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
7 years ago (2011-11-02 18:18:34 UTC) #2
r
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
7 years ago (2011-11-02 18:19:17 UTC) #3
bradfitz
http://codereview.appspot.com/5322067/diff/6001/src/pkg/builtin/builtin.go File src/pkg/builtin/builtin.go (right): http://codereview.appspot.com/5322067/diff/6001/src/pkg/builtin/builtin.go#newcode16 src/pkg/builtin/builtin.go:16: // uint8 is the set of all unsigned 8-bit ...
7 years ago (2011-11-02 18:23:58 UTC) #4
r
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
7 years ago (2011-11-02 18:29:41 UTC) #5
bradfitz
LGTM http://codereview.appspot.com/5322067/diff/4003/src/pkg/builtin/builtin.go File src/pkg/builtin/builtin.go (right): http://codereview.appspot.com/5322067/diff/4003/src/pkg/builtin/builtin.go#newcode16 src/pkg/builtin/builtin.go:16: // uint8 is the set of all unsigned ...
7 years ago (2011-11-02 18:36:01 UTC) #6
r
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
7 years ago (2011-11-02 18:37:44 UTC) #7
r2
all done. anyone else?
7 years ago (2011-11-02 18:37:52 UTC) #8
niemeyer
http://codereview.appspot.com/5322067/diff/3003/src/pkg/builtin/builtin.go File src/pkg/builtin/builtin.go (right): http://codereview.appspot.com/5322067/diff/3003/src/pkg/builtin/builtin.go#newcode67 src/pkg/builtin/builtin.go:67: // uintptr is an unsigned integer type that is ...
7 years ago (2011-11-02 18:39:35 UTC) #9
r
Hello golang-dev@googlegroups.com, bradfitz@golang.org, r@google.com, n13m3y3r@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
7 years ago (2011-11-02 18:40:15 UTC) #10
niemeyer
http://codereview.appspot.com/5322067/diff/9002/src/pkg/builtin/builtin.go File src/pkg/builtin/builtin.go (right): http://codereview.appspot.com/5322067/diff/9002/src/pkg/builtin/builtin.go#newcode68 src/pkg/builtin/builtin.go:68: // distinct type, however, and not an alias for, ...
7 years ago (2011-11-02 18:43:06 UTC) #11
r2
indeed, uint. i remembered uintptr though. PTAL
7 years ago (2011-11-02 18:44:23 UTC) #12
rsc
LGTM http://codereview.appspot.com/5322067/diff/19001/src/pkg/builtin/builtin.go File src/pkg/builtin/builtin.go (right): http://codereview.appspot.com/5322067/diff/19001/src/pkg/builtin/builtin.go#newcode69 src/pkg/builtin/builtin.go:69: type uint uint s/uint/int/g http://codereview.appspot.com/5322067/diff/19001/src/pkg/builtin/builtin.go#newcode73 src/pkg/builtin/builtin.go:73: type int ...
7 years ago (2011-11-02 18:58:15 UTC) #13
r2
On Nov 2, 2011, at 11:58 AM, rsc@golang.org wrote: > LGTM > > > > ...
7 years ago (2011-11-02 18:59:26 UTC) #14
r
7 years ago (2011-11-02 19:06:40 UTC) #15
*** Submitted as http://code.google.com/p/go/source/detail?r=3dd5a0ccc0e0 ***

builtin: document the basic types
The recursive definitions are illegal Go, but godoc doesn't mind.

R=bradfitz, r, n13m3y3r, rsc
CC=golang-dev
http://codereview.appspot.com/5322067
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b