Issue 5322044: code review 5322044: html: dump attributes when running parser tests.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5322044: code review 5322044: html: dump attributes when running parser tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 12 months ago by andybalholm

Modified:
14 years, 12 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

html: dump attributes when running parser tests. The WebKit test data shows attributes as though they were child nodes: <a X>0<b>1<a Y>2 dumps as: | <html> | <head> | <body> | <a> | x="" | "0" | <b> | "1" | <b> | <a> | y="" | "2" So we need to do the same when dumping a tree to compare with it.

Patch Set 1 #

Patch Set 2 : diff -r 5a6c90d25d31 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5a6c90d25d31 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 5a6c90d25d31 https://go.googlecode.com/hg/ #

Created: 14 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	src/pkg/html/parse_test.go	View	1	3 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 12 months ago (2011-10-24 18:19:28 UTC) #1

nigeltao

14 years, 12 months ago (2011-10-24 22:33:46 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=7b486f411fcb ***

html: dump attributes when running parser tests.

The WebKit test data shows attributes as though they were child nodes:

<a X>0<b>1<a Y>2
dumps as:
| <html>
|   <head>
|   <body>
|     <a>
|       x=""
|       "0"
|       <b>
|         "1"
|     <b>
|       <a>
|         y=""
|         "2"

So we need to do the same when dumping a tree to compare with it.

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/5322044

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages