Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(75)

Issue 5320053: code review 5320053: exp/ssh: add client functional tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by dave
Modified:
13 years, 4 months ago
Reviewers:
CC:
rsc, agl1, niemeyer, golang-dev
Visibility:
Public.

Description

exp/ssh: add client functional tests Requires CL 5373055

Patch Set 1 #

Patch Set 2 : diff -r b3069ca75051 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r 7955d5c97b6a https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
A src/pkg/exp/ssh/client_func_test.go View 1 2 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 10
dave_cheney.net
Hello rsc@golang.org, agl@golang.org, n13m3y3r@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2011-10-29 02:45:27 UTC) #1
rsc
These look fine to me. It would be great to have tests that the client ...
13 years, 4 months ago (2011-11-07 15:34:22 UTC) #2
rsc
LGTM Adam or Gustavo?
13 years, 4 months ago (2011-11-07 15:34:47 UTC) #3
agl1
LGTM. http://codereview.appspot.com/5320053/diff/1001/src/pkg/exp/ssh/client_test.go File src/pkg/exp/ssh/client_test.go (right): http://codereview.appspot.com/5320053/diff/1001/src/pkg/exp/ssh/client_test.go#newcode10 src/pkg/exp/ssh/client_test.go:10: // -ssh.user and -ssh.pass must be passed to ...
13 years, 4 months ago (2011-11-07 15:38:15 UTC) #4
niemeyer
When Adam first submitted the SSH server tests, I was actually privately considering the idea ...
13 years, 4 months ago (2011-11-07 16:35:43 UTC) #5
dave_cheney.net
Hello, Sorry it took me so long to reply. I think this is a wonderful ...
13 years, 4 months ago (2011-11-12 23:22:27 UTC) #6
dave_cheney.net
Please take another look. These tests require CL 5373055. nb. The session related tests have ...
13 years, 4 months ago (2011-11-13 08:59:41 UTC) #7
agl1
LGTM once the dependent change has landed.
13 years, 4 months ago (2011-11-13 16:52:19 UTC) #8
dave_cheney.net
PTAL. This change can be applied now.
13 years, 4 months ago (2011-11-13 20:29:36 UTC) #9
agl1
13 years, 4 months ago (2011-11-14 01:58:48 UTC) #10
*** Submitted as http://code.google.com/p/go/source/detail?r=9955a6883269 ***

exp/ssh: add client functional tests

Requires CL 5373055

R=rsc, agl, n13m3y3r
CC=golang-dev
http://codereview.appspot.com/5320053

Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b