code review 5320053: exp/ssh: add client functional tests

exp/ssh: add client functional tests

Requires CL 5373055

[dave_cheney.net, 2011-10-29 02:45:27]

Hello rsc@golang.org, agl@golang.org, n13m3y3r@gmail.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-11-07 15:34:22]

These look fine to me.  It would be great to have tests
that the client can connect to our own server too.
Those could run always.

[rsc, 2011-11-07 15:34:47]

LGTM

Adam or Gustavo?

[agl1, 2011-11-07 15:38:15]

LGTM.

http://codereview.appspot.com/5320053/diff/1001/src/pkg/exp/ssh/client_test.go
File src/pkg/exp/ssh/client_test.go (right):

http://codereview.appspot.com/5320053/diff/1001/src/pkg/exp/ssh/client_test.g...
src/pkg/exp/ssh/client_test.go:10: // -ssh.user and -ssh.pass must be passed to
gotest.
s/must/are/ ?

[niemeyer, 2011-11-07 16:35:43]

When Adam first submitted the SSH server tests, I was actually privately
considering the idea of creating an SSH server/client package for Go (thanks
Adam! ;-).

The first thing I did was a functional test suite that manages sshd itself so
that the suite won't require knowing real ssh config and credentials to run. It
should be trivial to make use of it to test exp/ssh for the same benefit:

    http://paste.ubuntu.com/731085/

What do you think, Dave?

[dave_cheney.net, 2011-11-12 23:22:27]

Hello,

Sorry it took me so long to reply. I think this is a wonderful idea as
there are a number of features that the server component does not
implement so writing some unit tests is not possible.

If you wanted to wrap this functionality into something like
client_func_test.go I can send you a patch of the most recent version
of these tests.

Cheers

Dave

On Tue, Nov 8, 2011 at 3:35 AM,  <n13m3y3r@gmail.com> wrote:
> When Adam first submitted the SSH server tests, I was actually privately
> considering the idea of creating an SSH server/client package for Go
> (thanks Adam! ;-).
>
> The first thing I did was a functional test suite that manages sshd
> itself so that the suite won't require knowing real ssh config and
> credentials to run. It should be trivial to make use of it to test
> exp/ssh for the same benefit:
>
>    http://paste.ubuntu.com/731085/
>
> What do you think, Dave?
>
> http://codereview.appspot.com/5320053/
>

[dave_cheney.net, 2011-11-13 08:59:41]

Please take another look.

These tests require CL 5373055.

nb. The session related tests have been withdrawn until CL 5322055 has been
reviewed.

[agl1, 2011-11-13 16:52:19]

LGTM once the dependent change has landed.

[dave_cheney.net, 2011-11-13 20:29:36]

PTAL. This change can be applied now.

[agl1, 2011-11-14 01:58:48]

*** Submitted as http://code.google.com/p/go/source/detail?r=9955a6883269 ***

exp/ssh: add client functional tests

Requires CL 5373055

R=rsc, agl, n13m3y3r
CC=golang-dev
http://codereview.appspot.com/5320053

Committer: Adam Langley <agl@golang.org>