code review 5319065: gc: small fixes for printing.

gc: small fixes for printing.

mark OADDR inserted by typecheck as implicit
OCOPY takes ->left and ->right, not ->list
OMAKE*'s can all have arguments
precedence for OIND was initalized twice

fixes issue 2414

[lvd, 2011-11-01 10:29:44]

Hello rsc@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-11-02 13:39:00]

LGTM

http://codereview.appspot.com/5319065/diff/2002/test/escape2.go
File test/escape2.go (right):

http://codereview.appspot.com/5319065/diff/2002/test/escape2.go#newcode151
test/escape2.go:151: return b.i[:]  // ERROR "b.i escapes to heap"
This bothers me a little: &b.i is what escaped to the heap: the address, not the
[12]int.  Is there an easy way to 
preserve the & in this message?  Maybe change the print
to say &%N ... n->left instead of %N ... n ?

[rsc, 2011-11-02 13:40:13]

one more thing: are you sure about the
placement of case OMAKE in that list?

[lvd, 2011-11-02 14:29:26]

On 2011/11/02 13:40:13, rsc wrote:
> one more thing: are you sure about the
> placement of case OMAKE in that list?

before typecheck, all args are in ->list, after that op is set to one of the
specific ones.  case OMAKE in typecheck jumps to error before setting ->left and
->right. so i think we're good.

[lvd, 2011-11-02 14:36:38]

*** Submitted as http://code.google.com/p/go/source/detail?r=b876d7be1480 ***

gc: small fixes for printing.

mark OADDR inserted by typecheck as implicit
OCOPY takes ->left and ->right, not ->list
OMAKE*'s can all have arguments
precedence for OIND was initalized twice

fixes issue 2414

R=rsc, dave
CC=golang-dev
http://codereview.appspot.com/5319065