src/cmd/gotest/gotest.go - Issue 5319057: code review 5319057: cgo, gotest: use error instead of os.Error in generated code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/cmd/gotest/gotest.go

Issue 5319057: code review 5319057: cgo, gotest: use error instead of os.Error in generated code (Closed)

Patch Set: diff -r 5693fcd351c4 https://go.googlecode.com/hg/ Created 13 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/cmd/gotest/gotest.go

===================================================================

--- a/src/cmd/gotest/gotest.go

+++ b/src/cmd/gotest/gotest.go

@@ -401,7 +401,6 @@

fmt.Fprintf(b, "import target_test %q\n", "./_xtest_")

}

fmt.Fprintf(b, "import %q\n", "testing")

- fmt.Fprintf(b, "import %q\n", "os")

fmt.Fprintf(b, "import %q\n", "regexp")

fmt.Fprintln(b) // for gofmt

@@ -454,7 +453,7 @@

var matchPat string

var matchRe *regexp.Regexp

-func matchString(pat, str string) (result bool, err os.Error) {

+func matchString(pat, str string) (result bool, err error) {

if matchRe == nil || matchPat != pat {

matchPat = pat

matchRe, err = regexp.Compile(matchPat)

« no previous file with comments | « src/cmd/cgo/out.go ('k') | no next file » | no next file with comments »