Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 5314065: scheme-tutorial.itely: avoid unnecessary copying (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by dak
Modified:
7 years, 7 months ago
Reviewers:
Ian Hulin (gmail), carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

scheme-tutorial.itely: avoid unnecessary copying

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -34 lines) Patch
M Documentation/extending/scheme-tutorial.itely View 6 chunks +27 lines, -34 lines 4 comments Download

Messages

Total messages: 3
Carl
LGTM Carl
7 years, 10 months ago (2011-10-28 20:51:38 UTC) #1
Ian Hulin (gmail)
David, I think you've updated an example in two places, and added material which needs ...
7 years, 10 months ago (2011-10-28 23:04:31 UTC) #2
dak
7 years, 10 months ago (2011-10-28 23:49:48 UTC) #3
On 2011/10/28 23:04:31, Ian Hulin (gmail) wrote:
> David,
> I think you've updated an example in two places, and added material which
needs
> to reference the second example after the first one.

I disagree.  I see only one example here.  The intermediate definition
of a Scheme function is just a temporary simplification: the function
is never used or demonstrated.  There is also no information how one
would actually get the information for passing into the Scheme
function at the Scheme level.

Since no attempt to do a complete example in Scheme is made, it would
be nonsensical to add complications only required for a full Scheme
version, only to drop them again later before even using them.

Since I don't have the time and energy to do this in the desired way
(I was just trying to correct an example in discord with reality,
making people think that about half of music-function-init.ly is
defective), I am marking this as Patch_abandoned and Frog, and maybe
somebody else can be interested in working on it until it meets the
required standards.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b