Issue 5313044: code review 5313044: html: fix escape_test.go for CSS escaper change 5306042.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5313044: code review 5313044: html: fix escape_test.go for CSS escaper change 5306042. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by nigeltao

Modified:
13 years, 2 months ago

Reviewers:
bradfitz

CC:
MikeSamuel, golang-dev

Visibility:
Public.

Description

html: fix escape_test.go for CSS escaper change 5306042.

Patch Set 1 #

Patch Set 2 : diff -r 64907024b8e4 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 64907024b8e4 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 64907024b8e4 https://go.googlecode.com/hg/ #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/exp/template/html/escape_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

nigeltao

Hello mikesamuel@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 2 months ago (2011-10-18 23:52:51 UTC) #1

nigeltao

*** Submitted as http://code.google.com/p/go/source/detail?r=95aeed942188 *** html: fix escape_test.go for CSS escaper change 5306042. R=mikesamuel CC=golang-dev ...

13 years, 2 months ago (2011-10-18 23:54:13 UTC) #2

MikeSamuel

13 years, 2 months ago (2011-10-18 23:57:32 UTC) #4

Sorry.
On Oct 18, 2011 6:52 PM, <nigeltao@golang.org> wrote:

> Reviewers: MikeSamuel,
>
> Message:
> Hello mikesamuel@gmail.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> html: fix escape_test.go for CSS escaper change 5306042.
>
> Please review this at
http://codereview.appspot.com/**5313044/<http://codereview.appspot.com/5313044/>
>
> Affected files:
>  M src/pkg/exp/template/html/**escape_test.go
>
>
> Index: src/pkg/exp/template/html/**escape_test.go
> ==============================**==============================**=======
> --- a/src/pkg/exp/template/html/**escape_test.go
> +++ b/src/pkg/exp/template/html/**escape_test.go
> @@ -394,7 +394,7 @@
>                {
>                        "styleStrSpecialsEncoded",
>                        `<a style="font-family: '{{"/**/'\";:// \\"}}',
> &quot;{{"/**/'\";:// \\"}}&quot;">`,
> -                       `<a style="font-family: '\2f**\2f\27\22\3b\3a\2f\2f
> \\', &quot;\2f**\2f\27\22\3b\3a\2f\**2f \\&quot;">`,
> +                       `<a style="font-family: '\2f**\2f\27\22\3b\3a\2f\2f
>  \\', &quot;\2f**\2f\27\22\3b\3a\2f\**2f  \\&quot;">`,
>                },
>                {
>                        "styleURLSpecialsEncoded",
>
>
>

Expand All Messages | Collapse All Messages