Issue 53101: Funnel output from renderers into a Concatenator.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 53101: Funnel output from renderers into a Concatenator. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 11 months ago by MikeSamuel

Modified:
16 years, 8 months ago

Reviewers:
MarkM

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Ihab and Mark realized that it's easier to do things like renderers with original source line mappings if all the renderers bottom out in a Concatenator instead of in an Appendable. This changes the API to make that a fact, though the pretty and minimal JS printers do not yet forward FilePositions through to the Concatenator too. Submitted @3467

Patch Set 1 #

Patch Set 2 : Funnel output from renderers into a Concatenator. #

Patch Set 3 : Funnel output from renderers into a Concatenator. #

Created: 16 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+263 lines, -307 lines)			Patch
M	src/com/google/caja/lang/css/CssPropertyPatterns.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/lang/html/HtmlDefinitions.java	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/com/google/caja/opensocial/DefaultGadgetRewriter.java	View		4 chunks	+6 lines, -7 lines	0 comments	Download
M	src/com/google/caja/opensocial/GadgetParser.java	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	src/com/google/caja/opensocial/applet/CajaApplet.java	View		3 chunks	+5 lines, -6 lines	0 comments	Download
M	src/com/google/caja/parser/css/CssPropertySignature.java	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/com/google/caja/parser/css/CssTree.java	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	src/com/google/caja/parser/html/Nodes.java	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	src/com/google/caja/parser/js/AbstractExpression.java	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	src/com/google/caja/parser/js/AbstractStatement.java	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	src/com/google/caja/parser/js/CajoledModule.java	View		8 chunks	+12 lines, -27 lines	0 comments	Download
M	src/com/google/caja/parser/js/Identifier.java	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	src/com/google/caja/parser/js/Minify.java	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/com/google/caja/parser/js/UncajoledModule.java	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/com/google/caja/parser/js/UseSubset.java	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	src/com/google/caja/parser/quasiliteral/Rewriter.java	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/com/google/caja/plugin/BuildServiceImplementation.java	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/com/google/caja/plugin/CssCompiler.java	View	1 2	3 chunks	+4 lines, -3 lines	0 comments	Download
M	src/com/google/caja/plugin/CssRewriter.java	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/com/google/caja/plugin/CssValidator.java	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/com/google/caja/plugin/HtmlCompiler.java	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/com/google/caja/plugin/PluginCompilerMain.java	View		4 chunks	+4 lines, -3 lines	0 comments	Download
M	src/com/google/caja/render/AbstractRenderer.java	View		2 chunks	+4 lines, -36 lines	0 comments	Download
M	src/com/google/caja/render/BufferingRenderer.java	View		3 chunks	+52 lines, -68 lines	0 comments	Download
M	src/com/google/caja/render/Concatenator.java	View		2 chunks	+49 lines, -5 lines	0 comments	Download
M	src/com/google/caja/render/CssPrettyPrinter.java	View		5 chunks	+9 lines, -13 lines	0 comments	Download
M	src/com/google/caja/render/Innocent.java	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/com/google/caja/render/JsLinePreservingPrinter.java	View		2 chunks	+3 lines, -8 lines	0 comments	Download
M	src/com/google/caja/render/JsMinimalPrinter.java	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	src/com/google/caja/render/JsPrettyPrinter.java	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	src/com/google/caja/render/SourceSnippetRenderer.java	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/com/google/caja/render/SourceSpansRenderer.java	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/com/google/caja/render/TabularSideBySideRenderer.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/reporting/RenderContext.java	View		2 chunks	+7 lines, -14 lines	0 comments	Download
M	tests/com/google/caja/opensocial/DefaultGadgetRewriterTest.java	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	tests/com/google/caja/parser/ParseTreeNodeTest.java	View		8 chunks	+15 lines, -21 lines	0 comments	Download
M	tests/com/google/caja/parser/css/CssTreeTest.java	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/com/google/caja/parser/js/ParserTest.java	View		3 chunks	+5 lines, -4 lines	0 comments	Download
M	tests/com/google/caja/parser/quasiliteral/ModuleFormatTest.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/com/google/caja/plugin/CssCompilerTest.java	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/com/google/caja/plugin/DomProcessingEventsTestData.java	View		3 chunks	+2 lines, -3 lines	0 comments	Download
M	tests/com/google/caja/plugin/HtmlCompiledPluginTest.java	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/com/google/caja/plugin/HtmlSanitizerTest.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/com/google/caja/plugin/stages/PipelineStageTestCase.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/com/google/caja/render/JsLinePreservingPrinterTest.java	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/com/google/caja/render/JsMinimalPrinterTest.java	View		6 chunks	+7 lines, -8 lines	0 comments	Download
M	tests/com/google/caja/render/JsPrettyPrinterTest.java	View		5 chunks	+5 lines, -6 lines	0 comments	Download
M	tests/com/google/caja/util/CajaTestCase.java	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	tests/com/google/caja/util/RhinoTestBed.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

MarkM

16 years, 11 months ago (2009-05-04 21:59:49 UTC) #2

Modulo one minor aesthetic "final" discussed verbally, LGTM.

Expand All Messages | Collapse All Messages