code review 5309052: html: implement foster parenting

html: implement foster parenting

Implement the foster-parenting algorithm for content that is inside a table
but not in a cell.

Also fix a bug in reconstructing the active formatting elements.

Pass test 30 in tests1.dat:
<a><table><td><a><table></table><a></tr><a></table><b>X</b>C<a>Y

[andybalholm, 2011-10-22 18:48:35]

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[nigeltao, 2011-10-22 22:50:05]

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go
File src/pkg/html/parse.go (right):

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go#newcode35
src/pkg/html/parse.go:35: // fosterParenting is turned on while new elements
should be inserted according to
// fosterParenting is whether new elements should be inserted according to the
// foster parenting rules (section 11.2.5.3).

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go#newcode120
src/pkg/html/parse.go:120: // fosterParent adds a child node according to the
foster-parenting rules.
Add `// Section 11.2.5.3, "foster parenting".`

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go#newcode122
src/pkg/html/parse.go:122: // Do foster parenting.
Delete this comment.

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go#newcode133
src/pkg/html/parse.go:133: parent = p.oe[0] // the html element
Move the comment to be above the code:
// The parent is the html element.

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go#newcode151
src/pkg/html/parse.go:151: parent.Child = append(parent.Child[:i+1],
parent.Child[i:]...)
Add a comment above this slice trick:
// Insert n into parent.Child at index i.

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go#newcode218
src/pkg/html/parse.go:218: n = p.afe[i]
Join this line with the next:
clone := p.afe[i].clone()

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go#newcode713
src/pkg/html/parse.go:713: // inBodyEndTagOther performs the "any other end tag"
algorithm for inBodyIM
Missing full stop.

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go#newcode740
src/pkg/html/parse.go:740: func (p *parser) clearStackToTableContext() {
I'd move this to be below the inTableIM func.

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse_test.go
File src/pkg/html/parse_test.go (right):

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse_test.go#ne...
src/pkg/html/parse_test.go:155: if filename == "tests1.dat" && i == 30 {
Huh. What does the render look like?

[andybalholm, 2011-10-22 23:24:08]

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[andybalholm, 2011-10-22 23:25:03]

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go
File src/pkg/html/parse.go (right):

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go#newcode35
src/pkg/html/parse.go:35: // fosterParenting is turned on while new elements
should be inserted according to
On 2011/10/22 22:50:06, nigeltao wrote:
> // fosterParenting is whether new elements should be inserted according to the
> // foster parenting rules (section 11.2.5.3).

Done.

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go#newcode120
src/pkg/html/parse.go:120: // fosterParent adds a child node according to the
foster-parenting rules.
On 2011/10/22 22:50:06, nigeltao wrote:
> Add `// Section 11.2.5.3, "foster parenting".`

Done.

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go#newcode122
src/pkg/html/parse.go:122: // Do foster parenting.
On 2011/10/22 22:50:06, nigeltao wrote:
> Delete this comment.

Done.

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go#newcode133
src/pkg/html/parse.go:133: parent = p.oe[0] // the html element
On 2011/10/22 22:50:06, nigeltao wrote:
> Move the comment to be above the code:
> // The parent is the html element.

Done.

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go#newcode151
src/pkg/html/parse.go:151: parent.Child = append(parent.Child[:i+1],
parent.Child[i:]...)
On 2011/10/22 22:50:06, nigeltao wrote:
> Add a comment above this slice trick:
> // Insert n into parent.Child at index i.

Done.

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go#newcode218
src/pkg/html/parse.go:218: n = p.afe[i]
On 2011/10/22 22:50:06, nigeltao wrote:
> Join this line with the next:
> clone := p.afe[i].clone()

Done.

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go#newcode713
src/pkg/html/parse.go:713: // inBodyEndTagOther performs the "any other end tag"
algorithm for inBodyIM
On 2011/10/22 22:50:06, nigeltao wrote:
> Missing full stop.

Done.

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse.go#newcode740
src/pkg/html/parse.go:740: func (p *parser) clearStackToTableContext() {
On 2011/10/22 22:50:06, nigeltao wrote:
> I'd move this to be below the inTableIM func.

Done.

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse_test.go
File src/pkg/html/parse_test.go (right):

http://codereview.appspot.com/5309052/diff/1001/src/pkg/html/parse_test.go#ne...
src/pkg/html/parse_test.go:155: if filename == "tests1.dat" && i == 30 {
On 2011/10/22 22:50:06, nigeltao wrote:
> Huh. What does the render look like?

<html><head></head><body><a><a></a><table><tbody><tr><td><a><table></table></a><a></a></td></tr></tbody></table></a><a><b>X</b>C</a><a>Y</a></body></html>

[nigeltao, 2011-10-23 07:15:49]

LGTM.

[nigeltao, 2011-10-23 07:37:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=e0f2cfa42ede ***

html: implement foster parenting

Implement the foster-parenting algorithm for content that is inside a table
but not in a cell.

Also fix a bug in reconstructing the active formatting elements.

Pass test 30 in tests1.dat:
<a><table><td><a><table></table><a></tr><a></table><b>X</b>C<a>Y

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/5309052

Committer: Nigel Tao <nigeltao@golang.org>