Issue 5306049: code review 5306049: net: do not set SO_REUSEADDR for windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5306049: code review 5306049: net: do not set SO_REUSEADDR for windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by brainman

Modified:
14 years, 12 months ago

Reviewers:
rsc

CC:
golang-dev, mikio

Visibility:
Public.

Description

net: do not set SO_REUSEADDR for windows Fixes issue 2307.

Patch Set 1 #

Patch Set 2 : diff -r 462b81e9ced4 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 462b81e9ced4 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e0f2cfa42ede https://go.googlecode.com/hg/ #

Created: 14 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	src/pkg/net/sock_windows.go	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com (cc: mikioh.mikioh@gmail.com), I'd like you to review this change to https://go.googlecode.com/hg/

15 years ago (2011-10-21 06:14:51 UTC) #1

mikio

LGTM On 2011/10/21 06:14:51, brainman wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:mikioh.mikioh@gmail.com), > > I'd like ...

15 years ago (2011-10-21 07:00:50 UTC) #2

brainman

*** Submitted as http://code.google.com/p/go/source/detail?r=5a6c90d25d31 *** net: do not set SO_REUSEADDR for windows Fixes issue 2307. ...

14 years, 12 months ago (2011-10-23 22:11:10 UTC) #3

rsc

14 years, 12 months ago (2011-10-24 16:20:20 UTC) #4

Sorry for the late review, but please add a comment
saying why SO_REUSEADDR isn't there (in contrast
to the other implementations).  Otherwise someone
will come along and think "hey, looks like they forgot
something" and re-add it.

Thanks.
Russ

Expand All Messages | Collapse All Messages