Issue 5306044: code review 5306044: bytes, strings: use rune

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5306044: code review 5306044: bytes, strings: use rune (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by rsc

Modified:
14 years, 12 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

bytes, strings: use rune Various rune-based APIs change.

Patch Set 1 #

Patch Set 2 : diff -r 3213129c689b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2036892ab207 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f926eabc3982 https://go.googlecode.com/hg/ #

Created: 14 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+189 lines, -187 lines)			Patch
M	src/pkg/bytes/buffer.go	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/bytes/buffer_test.go	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/bytes/bytes.go	View	1	15 chunks	+61 lines, -60 lines	0 comments	Download
M	src/pkg/bytes/bytes_test.go	View	1	10 chunks	+30 lines, -30 lines	0 comments	Download
M	src/pkg/strings/reader.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/strings/replace_test.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/strings/strings.go	View	1	14 chunks	+48 lines, -47 lines	0 comments	Download
M	src/pkg/strings/strings_test.go	View	1	13 chunks	+38 lines, -38 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

15 years ago (2011-10-19 17:26:57 UTC) #1

rsc

14 years, 12 months ago (2011-10-26 05:22:13 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=b1095ebb3bcb ***

bytes, strings: use rune

Various rune-based APIs change.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5306044

Expand All Messages | Collapse All Messages