Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(217)

Issue 53059: Fix build under JDK1.5 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 11 months ago by MikeSamuel
Modified:
16 years, 8 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

http://code.google.com/p/google-caja/issues/detail?id=1017 RichB reports Hi, I've got a build error compiling Caja. I checked out the head from svn and ran Ant and got this. I'm not a Java coder so apologies if this is a newbie mistake. Could someone please point me in the right direction. PluginCompiler: [javac] Compiling 28 source files to ... [javac] .../src/com/google/caja/plugin/Dom.java:43: method does not override a method from its superclass ... Fixed the compile issue and fixed a number of issues relating to running tests under 1.5. Many of these issues resolved around different iteration order in HashMaps for the two, but I also fixed issues around 1.5 using a stricter identifier normalization scheme due to the absence of java.text.normalizer. Submitted @3464

Patch Set 1 #

Patch Set 2 : Fix build under JDK1.5 #

Patch Set 3 : Fix build under JDK1.5 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -50 lines) Patch
M src/com/google/caja/opensocial/GadgetParser.java View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/com/google/caja/parser/css/CssTree.java View 1 chunk +0 lines, -1 line 0 comments Download
M src/com/google/caja/parser/js/CajoledModule.java View 2 3 chunks +5 lines, -5 lines 0 comments Download
M src/com/google/caja/parser/js/ObjectConstructor.java View 2 6 chunks +10 lines, -23 lines 0 comments Download
M src/com/google/caja/parser/quasiliteral/Permit.java View 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/com/google/caja/plugin/Dom.java View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M tests/com/google/caja/opensocial/service/CajolingServiceTest.java View 2 1 chunk +3 lines, -3 lines 0 comments Download
M tests/com/google/caja/parser/ParserBaseTest.java View 2 2 chunks +7 lines, -1 line 0 comments Download
M tests/com/google/caja/parser/js/ParserTest.java View 2 2 chunks +6 lines, -2 lines 1 comment Download
M tests/com/google/caja/parser/quasiliteral/ModuleFormatTest.java View 2 3 chunks +6 lines, -10 lines 0 comments Download
M tests/com/google/caja/util/TestUtil.java View 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2
MikeSamuel
16 years, 11 months ago (2009-04-30 03:06:35 UTC) #1
Jasvir
16 years, 11 months ago (2009-04-30 23:26:31 UTC) #2
LGTM

Thanks for running the tests against 1.5

http://codereview.appspot.com/53059/diff/1014/1017
File tests/com/google/caja/parser/js/ParserTest.java (right):

http://codereview.appspot.com/53059/diff/1014/1017#newcode96
Line 96: runParseTest("parsertest5.js", "parsergolden5.txt");
This tests the slightly larger set of valid characters in identifiers accepted
by Java6 so is ok to disable for Java 1.5.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b