Issue 5305090: code review 5305090: httputil: move ReverseProxy out of http

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5305090: code review 5305090: httputil: move ReverseProxy out of http (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by bradfitz

Modified:
13 years, 4 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

httputil: move ReverseProxy out of http http diet plan, continued.

Patch Set 2 : diff -r 095cf9590ffe https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 095cf9590ffe https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 23f8196d213f https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -22 lines)			Patch
M	src/pkg/Makefile	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/net/http/Makefile	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/pkg/net/http/httputil/Makefile	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/net/http/httputil/reverseproxy.go	View	1	8 chunks	+14 lines, -13 lines	0 comments	Download
M	src/pkg/net/http/httputil/reverseproxy_test.go	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-11-03 22:08:23 UTC) #1

adg

LGTM http://codereview.appspot.com/5305090/diff/5001/src/pkg/net/http/httputil/reverseproxy.go File src/pkg/net/http/httputil/reverseproxy.go (right): http://codereview.appspot.com/5305090/diff/5001/src/pkg/net/http/httputil/reverseproxy.go#newcode32 src/pkg/net/http/httputil/reverseproxy.go:32: Transport http.RoundTripper unrelated to this change: I would ...

13 years, 4 months ago (2011-11-03 22:46:22 UTC) #2

bradfitz

13 years, 4 months ago (2011-11-03 22:54:12 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=62a88d392930 ***

httputil: move ReverseProxy out of http

http diet plan, continued.

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/5305090

Expand All Messages | Collapse All Messages