Issue 5305088: code review 5305088: http: don't use ClientConn in Transport

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5305088: code review 5305088: http: don't use ClientConn in Transport (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by bradfitz

Modified:
13 years, 4 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

http: don't use ClientConn in Transport ClientConn's main feature (pipelining support) wasn't being used anyway. Ends up simpler to just not use it. This is prep for the http diet, moving ClientConn, ServerConn, etc into http/httputil.

Patch Set 1 #

Patch Set 2 : diff -r e1e97028a407 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e1e97028a407 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r cdf4e4406ff6 https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -29 lines)			Patch
	M	src/pkg/http/transport.go	View	1	8 chunks	+25 lines, -29 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-11-03 18:51:54 UTC) #1

bradfitz

13 years, 4 months ago (2011-11-03 19:35:59 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=9d2976cf80fc ***

http: don't use ClientConn in Transport

ClientConn's main feature (pipelining support)
wasn't being used anyway.  Ends up simpler to
just not use it.

This is prep for the http diet, moving ClientConn,
ServerConn, etc into http/httputil.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5305088

Expand All Messages | Collapse All Messages