Issue 5305079: code review 5305079: syscall/Await: '' from await() indicates correct comple...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5305079: code review 5305079: syscall/Await: '' from await() indicates correct comple... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 12 months ago by aam

Modified:
14 years, 12 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

syscall/Await: '' from await() indicates correct completion, set Waitmsg.Msg to "" Plan 9's await() returns '' for nil exit status but programs, most notably gotest, see this as an error return.

Patch Set 1 #

Patch Set 2 : diff -r 9fac03822c60 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9fac03822c60 https://go.googlecode.com/hg/ #

Created: 14 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/pkg/syscall/syscall_plan9.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

aam

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 12 months ago (2011-10-30 20:25:50 UTC) #1

rsc

14 years, 12 months ago (2011-10-31 17:35:01 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=07548da11316 ***

syscall: fix Await msg on Plan 9

Plan 9's await() returns '' for nil exit status but programs, most notably
gotest,
see this as an error return.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5305079

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages