src/cmd/gofix/signal.go - Issue 5305066: code review 5305066: gofix: error fix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/cmd/gofix/signal.go

Issue 5305066: code review 5305066: gofix: error fix (Closed)

Patch Set: diff -r 2be61232b4e2 https://go.googlecode.com/hg/ Created 13 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/cmd/gofix/signal.go

===================================================================

--- a/src/cmd/gofix/signal.go

+++ b/src/cmd/gofix/signal.go

@@ -32,16 +32,14 @@

sel := s.Sel.String()

if sel == "Signal" || sel == "UnixSignal" || strings.HasPrefix(sel, "SIG") {

+ addImport(f, "os")

s.X = &ast.Ident{Name: "os"}

fixed = true

}

})

- if fixed {

- addImport(f, "os")

- if !usesImport(f, "os/signal") {

- deleteImport(f, "os/signal")

- }

+ if fixed && !usesImport(f, "os/signal") {

+ deleteImport(f, "os/signal")

}

return

}

« no previous file with comments | « src/cmd/gofix/reflect.go ('k') | src/cmd/gofix/typecheck.go » ('j') | no next file with comments »