Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(164)

Issue 5302041: code review 5302041: weekly.2011-10-18 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by adg
Modified:
11 years, 1 month ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

weekly.2011-10-18

Patch Set 1 #

Total comments: 6

Patch Set 2 : diff -r eec8e79200f0 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r db65e054598e https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 95aeed942188 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -1 line) Patch
M .hgtags View 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/weekly.html View 1 2 1 chunk +131 lines, -0 lines 0 comments Download

Messages

Total messages: 6
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 1 month ago (2011-10-18 04:44:39 UTC) #1
rsc
http://codereview.appspot.com/5302041/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5302041/diff/1/doc/devel/weekly.html#newcode23 doc/devel/weekly.html:23: The most significant changes can be made automatically with ...
11 years, 1 month ago (2011-10-18 12:46:36 UTC) #2
adg
http://codereview.appspot.com/5302041/diff/1/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5302041/diff/1/doc/devel/weekly.html#newcode23 doc/devel/weekly.html:23: The most significant changes can be made automatically with ...
11 years, 1 month ago (2011-10-18 20:40:53 UTC) #3
rsc
LGTM http://codereview.appspot.com/5302041/diff/3001/doc/devel/weekly.html File doc/devel/weekly.html (right): http://codereview.appspot.com/5302041/diff/3001/doc/devel/weekly.html#newcode35 doc/devel/weekly.html:35: Receive-only channels (<-chan T) cannot be closed. Attempting ...
11 years, 1 month ago (2011-10-18 20:52:30 UTC) #4
adg
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 1 month ago (2011-10-19 00:02:10 UTC) #5
adg
11 years, 1 month ago (2011-10-19 00:32:26 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=6d7136d74b65 ***

weekly.2011-10-18

R=rsc
CC=golang-dev
http://codereview.appspot.com/5302041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b