code review 5302041: weekly.2011-10-18

weekly.2011-10-18

[adg, 2011-10-18 04:44:39]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-10-18 12:46:36]

http://codereview.appspot.com/5302041/diff/1/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/5302041/diff/1/doc/devel/weekly.html#newcode23
doc/devel/weekly.html:23: The most significant changes can be made automatically
with gofix.
I'd delete this and flag the gofixable changes.

http://codereview.appspot.com/5302041/diff/1/doc/devel/weekly.html#newcode28
doc/devel/weekly.html:28: delete(m, x)
Add:
The compiler still accepts m[x] = 0, false for now; even so, you can use gofix
to 
rewrite such assignments into delete(m, x).


I assume you are waiting for the compiler to actually accept delete.
I will send that in later today.

http://codereview.appspot.com/5302041/diff/1/doc/devel/weekly.html#newcode31
doc/devel/weekly.html:31: the result variables has been shadowed. Code that
breaks as a result of this
s/that breaks/rejected/

[adg, 2011-10-18 20:40:53]

http://codereview.appspot.com/5302041/diff/1/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/5302041/diff/1/doc/devel/weekly.html#newcode23
doc/devel/weekly.html:23: The most significant changes can be made automatically
with gofix.
On 2011/10/18 12:46:36, rsc wrote:
> I'd delete this and flag the gofixable changes.

Done.

http://codereview.appspot.com/5302041/diff/1/doc/devel/weekly.html#newcode28
doc/devel/weekly.html:28: delete(m, x)
On 2011/10/18 12:46:36, rsc wrote:
> Add:
> The compiler still accepts m[x] = 0, false for now; even so, you can use gofix
> to 
> rewrite such assignments into delete(m, x).

Done.

> I assume you are waiting for the compiler to actually accept delete.
> I will send that in later today.

Yes.

http://codereview.appspot.com/5302041/diff/1/doc/devel/weekly.html#newcode31
doc/devel/weekly.html:31: the result variables has been shadowed. Code that
breaks as a result of this
On 2011/10/18 12:46:36, rsc wrote:
> s/that breaks/rejected/

Done.

[rsc, 2011-10-18 20:52:30]

LGTM

http://codereview.appspot.com/5302041/diff/3001/doc/devel/weekly.html
File doc/devel/weekly.html (right):

http://codereview.appspot.com/5302041/diff/3001/doc/devel/weekly.html#newcode35
doc/devel/weekly.html:35: Receive-only channels (<-chan T) cannot be closed.
Attempting to do so will
change to
Receive-only channels (<-chan T) cannot be closed.
The compiler will diagnose such attempts.

[adg, 2011-10-19 00:02:10]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[adg, 2011-10-19 00:32:26]

*** Submitted as http://code.google.com/p/go/source/detail?r=6d7136d74b65 ***

weekly.2011-10-18

R=rsc
CC=golang-dev
http://codereview.appspot.com/5302041