code review 5297044: gotest: use $GCFLAGS like make does

gotest: use $GCFLAGS like make does

[rsc, 2011-10-19 02:52:42]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-10-19 03:26:11]

LGTM

On Tue, Oct 18, 2011 at 7:52 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> gotest: use $GCFLAGS like make does
>
> Please review this at
http://codereview.appspot.com/**5297044/<http://codereview.appspot.com/5297044/>
>
> Affected files:
>  M src/cmd/gotest/gotest.go
>
>
> Index: src/cmd/gotest/gotest.go
> ==============================**==============================**=======
> --- a/src/cmd/gotest/gotest.go
> +++ b/src/cmd/gotest/gotest.go
> @@ -153,8 +153,12 @@
>        if gc == "" {
>                gc = O + "g"
>        }
> -       XGC = []string{gc, "-I", "_test", "-o", "_xtest_." + O}
> -       GC = []string{gc, "-I", "_test", "_testmain.go"}
> +       var gcflags []string
> +       if gf := strings.TrimSpace(os.Getenv("**GCFLAGS")); gf != "" {
> +               gcflags = strings.Fields(gf)
> +       }
> +       XGC = append([]string{gc, "-I", "_test", "-o", "_xtest_." + O},
> gcflags...)
> +       GC = append(append([]string{gc, "-I", "_test"}, gcflags...),
> "_testmain.go")
>        gl := os.Getenv("GL")
>        if gl == "" {
>                gl = O + "l"
>
>
>

[rsc, 2011-10-19 17:10:25]

*** Submitted as http://code.google.com/p/go/source/detail?r=2036892ab207 ***

gotest: use $GCFLAGS like make does

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5297044