Issue 52970043: Issue 1505: Support generating list of team names for MCQ and MSQ question options

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 52970043: Issue 1505: Support generating list of team names for MCQ and MSQ question options (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by arnold.koroa

Modified:
10 years, 8 months ago

Reviewers:
damith

Visibility:
Public.

More Reviews

Description

Issue 1505: Support generating list of team names for MCQ and MSQ question options

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+376 lines, -89 lines)			Patch
M	src/main/java/teammates/common/datatransfer/FeedbackMcqQuestionDetails.java	View	4 chunks	+38 lines, -7 lines	1 comment	Download
M	src/main/java/teammates/common/datatransfer/FeedbackMsqQuestionDetails.java	View	4 chunks	+38 lines, -7 lines	0 comments	Download
M	src/main/resources/feedbackQuestionMcqEditFormTemplate.html	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	src/main/resources/feedbackQuestionMsqEditFormTemplate.html	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	src/main/webapp/js/instructorFeedbackEdit.js	View	2 chunks	+30 lines, -6 lines	0 comments	Download
M	src/main/webapp/jsp/instructorFeedbackEdit.jsp	View	3 chunks	+18 lines, -10 lines	0 comments	Download
M	src/main/webapp/stylesheets/instructorFeedbacks.css	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackEditPageUiTest.java	View	3 chunks	+61 lines, -4 lines	0 comments	Download
M	src/test/java/teammates/test/pageobjects/AppPage.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/test/java/teammates/test/pageobjects/InstructorFeedbackEditPage.java	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackAddSuccess.html	View	3 chunks	+14 lines, -4 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackEditEmpty.html	View	3 chunks	+13 lines, -4 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackEditPublished.html	View	3 chunks	+13 lines, -4 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackEditSuccess.html	View	3 chunks	+13 lines, -4 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackMcqQuestionAddSuccess.html	View	4 chunks	+19 lines, -5 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackMcqQuestionEditSuccess.html	View	4 chunks	+26 lines, -12 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackMsqQuestionAddSuccess.html	View	4 chunks	+19 lines, -5 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackMsqQuestionEditSuccess.html	View	4 chunks	+19 lines, -5 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackQuestionAddSuccess.html	View	3 chunks	+13 lines, -4 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackQuestionEditSuccess.html	View	3 chunks	+13 lines, -4 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

damith

10 years, 8 months ago (2014-01-16 03:36:06 UTC) #1

https://codereview.appspot.com/52970043/diff/1/src/main/java/teammates/common...
File src/main/java/teammates/common/datatransfer/FeedbackMcqQuestionDetails.java
(right):

https://codereview.appspot.com/52970043/diff/1/src/main/java/teammates/common...
src/main/java/teammates/common/datatransfer/FeedbackMcqQuestionDetails.java:169:
Assumption.fail("Trying to generate options for neither students, teams no
instructors");
no -> nor?

Expand All Messages | Collapse All Messages