src/pkg/testing/iotest/logger.go - Issue 5294074: code review 5294074: src/pkg/[n-z]*: gofix -r error

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/testing/iotest/logger.go

Issue 5294074: code review 5294074: src/pkg/[n-z]*: gofix -r error (Closed)

Patch Set: diff -r b78bb4f2d2a3 https://go.googlecode.com/hg/ Created 13 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/testing/iotest/logger.go

===================================================================

--- a/src/pkg/testing/iotest/logger.go

+++ b/src/pkg/testing/iotest/logger.go

@@ -7,7 +7,6 @@

import (

"io"

"log"

- "os"

)

type writeLogger struct {

@@ -15,7 +14,7 @@

w io.Writer

}

-func (l *writeLogger) Write(p []byte) (n int, err os.Error) {

+func (l *writeLogger) Write(p []byte) (n int, err error) {

n, err = l.w.Write(p)

if err != nil {

log.Printf("%s %x: %v", l.prefix, p[0:n], err)

@@ -37,7 +36,7 @@

r io.Reader

}

-func (l *readLogger) Read(p []byte) (n int, err os.Error) {

+func (l *readLogger) Read(p []byte) (n int, err error) {

n, err = l.r.Read(p)

if err != nil {

log.Printf("%s %x: %v", l.prefix, p[0:n], err)

« no previous file with comments | « src/pkg/testing/example.go ('k') | src/pkg/testing/iotest/reader.go » ('j') | no next file with comments »