Issue 5294042: code review 5294042: build: pass $GCFLAGS to compiler

Issue 5294042: code review 5294042: build: pass $GCFLAGS to compiler (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by rsc

Modified:
15 years ago

Reviewers:

CC:
golang-dev, bradfitz, lvd

Visibility:
Public.

Description

build: pass $GCFLAGS to compiler For example, if you are debugging an optimization problem you can now run GCFLAGS=-N gotest This is a convention for make, not for the general build, so it may go away or be done differently in the eventual 'go' command. The plan is that people will be able to test their code for rune safety by doing GCFLAGS=-r.

Patch Set 1 #

Patch Set 2 : diff -r 96df3afe1c8a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 96df3afe1c8a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 02e06db88f3a https://go.googlecode.com/hg/ #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
M	src/Make.cmd	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/Make.pkg	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/run	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

15 years ago (2011-10-18 15:23:18 UTC) #1

bradfitz

LGTM This will also be useful for benchmarks with and without -b. On Tue, Oct ...

15 years ago (2011-10-18 16:00:43 UTC) #2

LGTM

This will also be useful for benchmarks with and without -b.

On Tue, Oct 18, 2011 at 8:23 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> build: pass $GCFLAGS to compiler
>
> For example, if you are debugging an optimization
> problem you can now run
>
>        GCFLAGS=-N gotest
>
> This is a convention for make, not for the general build,
> so it may go away or be done differently in the eventual
> 'go' command.
>
> The plan is that people will be able to test their code for
> rune safety by doing GCFLAGS=-r.
>
> Please review this at
http://codereview.appspot.com/**5294042/<http://codereview.appspot.com/5294042/>
>
> Affected files:
>  M src/Make.cmd
>  M src/Make.pkg
>  M test/run
>
>
> Index: src/Make.cmd
> ==============================**==============================**=======
> --- a/src/Make.cmd
> +++ b/src/Make.cmd
> @@ -20,7 +20,7 @@
>        $(LD) $(LDIMPORTS) -o $@ _go_.$O
>
>  _go_.$O: $(GOFILES) $(PREREQ)
> -       $(GC) $(GCIMPORTS) -o $@ $(GOFILES)
> +       $(GC) $(GCFLAGS) $(GCIMPORTS) -o $@ $(GOFILES)
>
>  install: $(TARGDIR)/$(TARG)
>
> @@ -44,7 +44,7 @@
>        gopack grc $@ _gotest_.$O
>
>  _gotest_.$O: $(GOFILES) $(GOTESTFILES)
> -       $(GC) $(GCIMPORTS) -o $@ $(GOFILES) $(GOTESTFILES)
> +       $(GC) $(GCFLAGS) $(GCIMPORTS) -o $@ $(GOFILES) $(GOTESTFILES)
>
>  importpath:
>        echo main
> Index: src/Make.pkg
> ==============================**==============================**=======
> --- a/src/Make.pkg
> +++ b/src/Make.pkg
> @@ -83,10 +83,10 @@
>        cp _obj/$(TARG).a "$@"
>
>  _go_.$O: $(GOFILES) $(PREREQ)
> -       $(GC) $(GCIMPORTS) -p $(TARG) -o $@ $(GOFILES)
> +       $(GC) $(GCFLAGS) $(GCIMPORTS) -p $(TARG) -o $@ $(GOFILES)
>
>  _gotest_.$O: $(GOFILES) $(GOTESTFILES) $(PREREQ)
> -       $(GC) $(GCIMPORTS) -p $(TARG) -o $@ $(GOFILES) $(GOTESTFILES)
> +       $(GC) $(GCFLAGS) $(GCIMPORTS) -p $(TARG) -o $@ $(GOFILES)
> $(GOTESTFILES)
>
>  _obj/$(TARG).a: _go_.$O $(OFILES)
>        @mkdir -p _obj/$(dir)
> Index: test/run
> ==============================**==============================**=======
> --- a/test/run
> +++ b/test/run
> @@ -23,7 +23,7 @@
>        exit 1
>  esac
>
> -export G=${A}g
> +export G="${A}g ${GCFLAGS}"
>  export L=${A}l
>  export GOTRACEBACK=0
>  export LANG=C
>
>
>

lvd

and inlining and escape analysis! LGTM++ On Oct 18, 2011 6:00 PM, "Brad Fitzpatrick" <bradfitz@golang.org> ...

15 years ago (2011-10-18 16:04:40 UTC) #3

and inlining and escape analysis! LGTM++
On Oct 18, 2011 6:00 PM, "Brad Fitzpatrick" <bradfitz@golang.org> wrote:

> LGTM
>
> This will also be useful for benchmarks with and without -b.
>
> On Tue, Oct 18, 2011 at 8:23 AM, <rsc@golang.org> wrote:
>
>> Reviewers: golang-dev_googlegroups.com,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://go.googlecode.com/hg/
>>
>>
>> Description:
>> build: pass $GCFLAGS to compiler
>>
>> For example, if you are debugging an optimization
>> problem you can now run
>>
>>        GCFLAGS=-N gotest
>>
>> This is a convention for make, not for the general build,
>> so it may go away or be done differently in the eventual
>> 'go' command.
>>
>> The plan is that people will be able to test their code for
>> rune safety by doing GCFLAGS=-r.
>>
>> Please review this at
http://codereview.appspot.com/**5294042/<http://codereview.appspot.com/5294042/>
>>
>> Affected files:
>>  M src/Make.cmd
>>  M src/Make.pkg
>>  M test/run
>>
>>
>> Index: src/Make.cmd
>> ==============================**==============================**=======
>> --- a/src/Make.cmd
>> +++ b/src/Make.cmd
>> @@ -20,7 +20,7 @@
>>        $(LD) $(LDIMPORTS) -o $@ _go_.$O
>>
>>  _go_.$O: $(GOFILES) $(PREREQ)
>> -       $(GC) $(GCIMPORTS) -o $@ $(GOFILES)
>> +       $(GC) $(GCFLAGS) $(GCIMPORTS) -o $@ $(GOFILES)
>>
>>  install: $(TARGDIR)/$(TARG)
>>
>> @@ -44,7 +44,7 @@
>>        gopack grc $@ _gotest_.$O
>>
>>  _gotest_.$O: $(GOFILES) $(GOTESTFILES)
>> -       $(GC) $(GCIMPORTS) -o $@ $(GOFILES) $(GOTESTFILES)
>> +       $(GC) $(GCFLAGS) $(GCIMPORTS) -o $@ $(GOFILES) $(GOTESTFILES)
>>
>>  importpath:
>>        echo main
>> Index: src/Make.pkg
>> ==============================**==============================**=======
>> --- a/src/Make.pkg
>> +++ b/src/Make.pkg
>> @@ -83,10 +83,10 @@
>>        cp _obj/$(TARG).a "$@"
>>
>>  _go_.$O: $(GOFILES) $(PREREQ)
>> -       $(GC) $(GCIMPORTS) -p $(TARG) -o $@ $(GOFILES)
>> +       $(GC) $(GCFLAGS) $(GCIMPORTS) -p $(TARG) -o $@ $(GOFILES)
>>
>>  _gotest_.$O: $(GOFILES) $(GOTESTFILES) $(PREREQ)
>> -       $(GC) $(GCIMPORTS) -p $(TARG) -o $@ $(GOFILES) $(GOTESTFILES)
>> +       $(GC) $(GCFLAGS) $(GCIMPORTS) -p $(TARG) -o $@ $(GOFILES)
>> $(GOTESTFILES)
>>
>>  _obj/$(TARG).a: _go_.$O $(OFILES)
>>        @mkdir -p _obj/$(dir)
>> Index: test/run
>> ==============================**==============================**=======
>> --- a/test/run
>> +++ b/test/run
>> @@ -23,7 +23,7 @@
>>        exit 1
>>  esac
>>
>> -export G=${A}g
>> +export G="${A}g ${GCFLAGS}"
>>  export L=${A}l
>>  export GOTRACEBACK=0
>>  export LANG=C
>>
>>
>>
>

rsc

15 years ago (2011-10-18 18:55:13 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=f84853b94305 ***

build: pass $GCFLAGS to compiler

For example, if you are debugging an optimization
problem you can now run

        GCFLAGS=-N gotest

This is a convention for make, not for the general build,
so it may go away or be done differently in the eventual
'go' command.

The plan is that people will be able to test their code for
rune safety by doing GCFLAGS=-r.

R=golang-dev, bradfitz, lvd
CC=golang-dev
http://codereview.appspot.com/5294042

Expand All Messages | Collapse All Messages