code review 5293058: fmt: simplify the code some more by storing the field i...

fmt: simplify the code some more by storing the field in the pp structure.

[r, 2011-10-21 20:12:52]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-10-21 20:40:50]

LGTM

http://codereview.appspot.com/5293058/diff/1/src/pkg/fmt/print.go
File src/pkg/fmt/print.go (right):

http://codereview.appspot.com/5293058/diff/1/src/pkg/fmt/print.go#newcode656
src/pkg/fmt/print.go:656: p.field = field
add
p.value = reflect.Value{}
just for cleanliness?

http://codereview.appspot.com/5293058/diff/1/src/pkg/fmt/print.go#newcode744
src/pkg/fmt/print.go:744: if value.CanInterface() {
Not 100% sure but I'd be more comfortable with

p.field = nil

before this if.  Otherwise I worry about handleMethods seeing some old field
when processing a nested data structure.

package main

import (
	"fmt"
	"os"
)

type T struct {
	X os.Error
	y int
}

func main() {
	fmt.Printf("%v\n", &T{X: os.NewError("x"), y: 2})
}

[r, 2011-10-21 20:59:34]

*** Submitted as http://code.google.com/p/go/source/detail?r=b8d3c48ba72d ***

fmt: simplify the code some more by storing the field in the pp structure.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5293058