Issue 5293050: Remove unnecessary retention of parse tree nodes in an unused message queue

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5293050: Remove unnecessary retention of parse tree nodes in an unused message queue (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by Jasvir

Modified:
14 years, 1 month ago

Reviewers:
felix8a

Base URL:
https://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

* CssParser and CssSanitizer don't do any message reporting and as such do not need to use a message queue that retains parse tree nodes.

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssParser.java	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssSanitizer.java	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 1

lgtm