code review 5293045: net/dial: remove duplicate error information.

net/dial: remove duplicate error information.

[aam, 2011-10-18 17:44:18]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-10-18 17:45:35]

Can you add a simple test?

Thanks.
Russ

[aam, 2011-10-18 18:17:33]

seems that a couple of the test cases need fixing too, should they be
looked at separately?

--- FAIL: net.TestDialError (0.08 seconds)
	#4: "dial tcp no-such-name:80: lookup no-such-name: no such host",
want match for `dial tcp no-such-name:80: lookup
no-such-name\.(.*\.)?( on .*)?: no (.*)`
	#5: "dial tcp mh/astro/r70:http: lookup mh/astro/r70: no such host",
want match for `dial tcp mh/astro/r70:http: lookup mh/astro/r70:
invalid domain name`
	#8: "dial unixpacket /etc/file-not-found: dial unixpacket
/etc/file-not-found: protocol not supported", want match for `dial
unixpacket /etc/file-not-found: no such file or directory`
	#9: "dial unixpacket /etc/: dial unixpacket /etc/: protocol not
supported", want match for `dial unixpacket /etc/: (permission
denied|socket operation on non-socket|connection refused)`
FAIL

[aam, 2011-10-18 18:24:47]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[aam, 2011-10-18 18:27:33]

those errors may be particular to osx. anyways, here's how the test looked
with the old code (i've left only the duplicate errors):


$ gotest -run_error_test
rm -f _test/net.a
rm -f _test/net.a
gopack grc _test/net.a _gotest_.6  _cgo_defun.6 _cgo_import.6 cgo_bsd.cgo2.o
cgo_unix.cgo2.o _cgo_export.o
--- FAIL: net.TestDialError (0.07 seconds)
#6: "dial unix /etc/file-not-found: dial unix /etc/file-not-found: no such
file or directory", duplicate error return from Dial
#7: "dial unix /etc/: dial unix /etc/: socket operation on non-socket",
duplicate error return from Dial
#8: "dial unixpacket /etc/file-not-found: dial unixpacket
/etc/file-not-found: protocol not supported", duplicate error return from
Dial
#9: "dial unixpacket /etc/: dial unixpacket /etc/: protocol not supported",
duplicate error return from Dial
FAIL

[rsc, 2011-10-18 18:49:05]

On Oct 18, 2011 at 14:17, andrey mirtchovski wrote:
> seems that a couple of the test cases need fixing too, should they be
> looked at separately?

sounds good to me (separately).

russ

[rsc, 2011-10-18 18:50:22]

LGTM

Thanks.

[rsc, 2011-10-18 18:51:45]

*** Submitted as http://code.google.com/p/go/source/detail?r=02e06db88f3a ***

net: remove duplicate error information in Dial

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5293045

Committer: Russ Cox <rsc@golang.org>