Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1856)

Issue 5286051: code review 5286051: [release-branch.r60] reflect: disallow Interface method... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by rsc
Modified:
11 years, 3 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

[release-branch.r60] reflect: disallow Interface method on Value obtained via unexported name exp/datafmt is incompatible with this change, so delete it. It was scheduled for deletion soon anyway. ««« CL 5266054 / f798c2579fbd reflect: disallow Interface method on Value obtained via unexported name Had been allowing it for use by fmt, but it is too hard to lock down. Fix other packages not to depend on it. R=r, r CC=golang-dev http://codereview.appspot.com/5266054 »»»

Patch Set 1 #

Patch Set 2 : diff -r 32a5db196298 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 32a5db196298 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -1588 lines) Patch
M src/pkg/Makefile View 1 1 chunk +0 lines, -1 line 0 comments Download
R src/pkg/exp/datafmt/Makefile View 1 1 chunk +0 lines, -12 lines 0 comments Download
R src/pkg/exp/datafmt/datafmt.go View 1 1 chunk +0 lines, -710 lines 0 comments Download
R src/pkg/exp/datafmt/datafmt_test.go View 1 1 chunk +0 lines, -330 lines 0 comments Download
R src/pkg/exp/datafmt/parser.go View 1 1 chunk +0 lines, -368 lines 0 comments Download
M src/pkg/fmt/fmt_test.go View 1 5 chunks +8 lines, -8 lines 0 comments Download
M src/pkg/fmt/print.go View 1 22 chunks +154 lines, -97 lines 0 comments Download
M src/pkg/reflect/all_test.go View 1 4 chunks +90 lines, -25 lines 0 comments Download
M src/pkg/reflect/deepequal.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/reflect/value.go View 1 3 chunks +15 lines, -16 lines 0 comments Download
M test/interface/fake.go View 1 2 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 3 months ago (2011-10-17 22:57:24 UTC) #1
rsc
Two notes: 1. Applied the patch manually (using hg patch) because it needed some fuzz ...
11 years, 3 months ago (2011-10-17 22:58:48 UTC) #2
r
LGTM
11 years, 3 months ago (2011-10-17 22:59:00 UTC) #3
rsc
11 years, 3 months ago (2011-10-17 23:01:31 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=01fa62f5e4e5 ***

[release-branch.r60] reflect: disallow Interface method on Value obtained via
unexported name

exp/datafmt is incompatible with this change, so delete it.
It was scheduled for deletion soon anyway.

««« CL 5266054 / f798c2579fbd
reflect: disallow Interface method on Value obtained via unexported name

Had been allowing it for use by fmt, but it is too hard to lock down.
Fix other packages not to depend on it.

R=r, r
CC=golang-dev
http://codereview.appspot.com/5266054
»»»

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5286051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b