Issue 5285044: code review 5285044: exp/ssh: general cleanups for client support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5285044: code review 5285044: exp/ssh: general cleanups for client support (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by dave

Modified:
14 years, 11 months ago

Reviewers:

CC:
golang-dev, agl1, rsc

Visibility:
Public.

Description

exp/ssh: general cleanups for client support common.go: * simplify findAgreedAlgorithms. * add channelExtendedData support. messages.go: * add clientExtendedData. server.go: * use simplified findAgreedAlgorithms. server_shell.go: * fix shadowed err return value. transport.go: * introduce separate cipher, mac and compression for each direction. * added filteredConn and packetWriter interfaces. * newTransport requires a source of randomness.

Patch Set 1 #

Patch Set 2 : diff -r 54ad84f87619 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 54ad84f87619 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 54ad84f87619 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 695f7459c6bb https://go.googlecode.com/hg/ #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -25 lines)			Patch
M	src/pkg/exp/ssh/common.go	View	1	2 chunks	+7 lines, -7 lines	0 comments	Download
M	src/pkg/exp/ssh/messages.go	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download
M	src/pkg/exp/ssh/server.go	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/exp/ssh/server_shell.go	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/exp/ssh/transport.go	View	1 2 3 4	4 chunks	+29 lines, -15 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

15 years ago (2011-10-14 22:42:49 UTC) #1

agl1

LGTM. (Sorry: this got lost in the flow of email. Please do poke me if ...

15 years ago (2011-10-18 15:21:27 UTC) #3

agl1

15 years ago (2011-10-18 16:55:13 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=aecd9f4061e0 ***

exp/ssh: general cleanups for client support

common.go:
* simplify findAgreedAlgorithms.
* add channelExtendedData support.

messages.go:
* add clientExtendedData.

server.go:
*  use simplified findAgreedAlgorithms.

server_shell.go:
* fix shadowed err return value.

transport.go:
* introduce separate cipher, mac and compression for each direction.
* added filteredConn and packetWriter interfaces.
* newTransport requires a source of randomness.

R=golang-dev, agl, rsc
CC=golang-dev
http://codereview.appspot.com/5285044

Committer: Adam Langley <agl@golang.org>

Expand All Messages | Collapse All Messages