Issue 5285042: code review 5285042: runtime: random offset for map iteration

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5285042: code review 5285042: runtime: random offset for map iteration (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by rsc

Modified:
13 years, 6 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

runtime: random offset for map iteration

Patch Set 1 #

Patch Set 2 : diff -r 4f8aab94dfd3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5ebff4e7b666 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f798c2579fbd https://go.googlecode.com/hg/ #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -19 lines)			Patch
M	doc/go_spec.html	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/cmd/gc/go.h	View	1 2 3	1 chunk	+10 lines, -8 lines	0 comments	Download
M	src/pkg/runtime/hashmap.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/hashmap.c	View	1 2 3	4 chunks	+49 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 6 months ago (2011-10-17 18:40:21 UTC) #1

spec change looks fine mike should do the code review. i'll loop him in.

13 years, 6 months ago (2011-10-17 18:50:07 UTC) #2

LGTM mike says: It looks good. Two comments; In hash_map.h, I'd put short comments on ...

13 years, 6 months ago (2011-10-17 20:46:05 UTC) #3

rsc

13 years, 6 months ago (2011-10-17 22:49:05 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=02c15930f43c ***

runtime: random offset for map iteration

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5285042

Expand All Messages | Collapse All Messages