code review 5279049: http: fix panic when recovering from hijacked connectio...

http: fix panic when recovering from hijacked connection panic

Fixes issue 2375.

[adg, 2011-10-17 04:32:18]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-10-17 04:53:34]

LGTM

[adg, 2011-10-17 04:54:42]

*** Submitted as http://code.google.com/p/go/source/detail?r=8c6f3c5bae77 ***

http: fix panic when recovering from hijacked connection panic

Fixes issue 2375.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5279049

[rsc, 2011-10-17 15:50:39]

This can't have fixed anything; there's no test.

[bradfitzgoog, 2011-10-17 16:04:02]

I bit my tongue (and/or was in a charitable mood) last night when I LGTM'd.
 I was starting to feel like a broken record about testing.  Thanks for the
reinforcement.  :-)


On Mon, Oct 17, 2011 at 8:50 AM, Russ Cox <rsc@golang.org> wrote:

> This can't have fixed anything; there's no test.
>

[adg, 2011-10-17 20:44:50]

I will add a test. Believe it or not, it does fix a real problem.

On 18 October 2011 03:04, Brad Fitzpatrick <bradfitz@google.com> wrote:
> I bit my tongue (and/or was in a charitable mood) last night when I LGTM'd.
>  I was starting to feel like a broken record about testing.  Thanks for the
> reinforcement.  :-)
>
> On Mon, Oct 17, 2011 at 8:50 AM, Russ Cox <rsc@golang.org> wrote:
>>
>> This can't have fixed anything; there's no test.
>
>