code review 5272045: go spec: "delete" built-in function

go spec: "delete" built-in function

[gri, 2011-10-13 21:17:43]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-10-13 21:21:22]

LGTM

[rsc, 2011-10-13 21:48:23]

LGTM

Maybe the tag should just be Delete.
(for http://golang.org/doc/go_spec.html#Delete)

[gri, 2011-10-13 22:00:13]

On Thu, Oct 13, 2011 at 2:48 PM, Russ Cox <rsc@golang.org> wrote:
> LGTM
>
> Maybe the tag should just be Delete.
> (for http://golang.org/doc/go_spec.html#Delete)

I just followed the existing convention.

As an aside: I've searched for all occurrences of "map" in the
document, and as far as I can tell we never state explicitly what m[k]
= x does. I should probably add this before submitting.

- Robert

[rsc, 2011-10-17 19:18:05]

ping?

can you submit this as is and then add
the map assignment clarification in a different CL?
i have CLs that introduce delete waiting on this one.

thanks.
russ

[gri, 2011-10-17 19:53:16]

*** Submitted as http://code.google.com/p/go/source/detail?r=315ea51607df ***

go spec: "delete" built-in function

R=golang-dev, r, rsc
CC=golang-dev
http://codereview.appspot.com/5272045