Issue 52710047: Call TracingController::GetMonitoringStatus when about:tracing is loaded

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 52710047: Call TracingController::GetMonitoringStatus when about:tracing is loaded (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by haraken

Modified:
11 years, 7 months ago

Reviewers:
dsinclair, nduca, Xianzhu

CC:
trace-viewer-review_googlegroups.com

Base URL:
http://trace-viewer.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Call TracingController::GetMonitoringStatus when about:tracing is loaded This CL makes profiling_view.js call TracingController::GetMonitoringStatus when starting about:tracing. Without doing this, reloaded about:tracing fails in extracting the current monitoring status. For more details, see a description in https://codereview.chromium.org/139313005/ R=nduca@chromium.org Committed: https://code.google.com/p/trace-viewer/source/detail?r=1089

Patch Set 1 #

Patch Set 2 : Updated profiling_view_test.js #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -62 lines)			Patch
M	src/about_tracing/profiling_view.js	View	1	7 chunks	+60 lines, -49 lines	0 comments	Download
M	src/about_tracing/profiling_view_test.js	View	1	6 chunks	+26 lines, -11 lines	0 comments	Download
M	src/about_tracing/tracing_ui_client.js	View		4 chunks	+27 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Message was sent while issue was closed.

Committed patchset #2 manually as r1089.

Expand All Messages | Collapse All Messages