Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(200)

Issue 5262041: code review 5262041: crypto/tls: fetch root certificates using Mac OS API (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by mkrautz
Modified:
8 years, 5 months ago
Reviewers:
CC:
adg, rsc, golang-dev
Visibility:
Public.

Description

crypto/tls: fetch root certificates using Mac OS API Fixes issue 1009.

Patch Set 1 #

Patch Set 2 : diff -r 988a7f023895 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 988a7f023895 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 988a7f023895 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 988a7f023895 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 988a7f023895 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 988a7f023895 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 8 : diff -r 988a7f023895 https://go.googlecode.com/hg/ #

Patch Set 9 : diff -r 988a7f023895 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 10 : diff -r 988a7f023895 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -31 lines) Patch
M src/pkg/crypto/tls/Makefile View 1 1 chunk +18 lines, -0 lines 0 comments Download
M src/pkg/crypto/tls/common.go View 1 2 3 4 5 6 7 4 chunks +12 lines, -25 lines 0 comments Download
M src/pkg/crypto/tls/handshake_client.go View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -4 lines 0 comments Download
M src/pkg/crypto/tls/handshake_server_test.go View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A src/pkg/crypto/tls/root_darwin.go View 1 1 chunk +95 lines, -0 lines 0 comments Download
A src/pkg/crypto/tls/root_stub.go View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
A src/pkg/crypto/tls/root_test.go View 1 2 3 4 5 6 7 1 chunk +36 lines, -0 lines 0 comments Download
A src/pkg/crypto/tls/root_unix.go View 1 1 chunk +27 lines, -0 lines 0 comments Download
M src/pkg/http/serve_test.go View 1 2 3 4 5 6 7 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 13
mkrautz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
8 years, 5 months ago (2011-10-13 01:06:22 UTC) #1
mkrautz
I haven't been able to test this on Snow Leopard yet. Neither a Go binary ...
8 years, 5 months ago (2011-10-13 01:16:11 UTC) #2
adg
On my Snow Leopard machine: $ gomake test gotest rm -f _test/crypto/tls.a CGOPKGPATH=crypto cgo -- ...
8 years, 5 months ago (2011-10-13 03:25:35 UTC) #3
mkrautz
On 2011/10/13 03:25:35, adg wrote: > On my Snow Leopard machine: > > $ gomake ...
8 years, 5 months ago (2011-10-13 13:38:29 UTC) #4
rsc
Thank you! This is great. I will be able to test on Snow Leopard and ...
8 years, 5 months ago (2011-10-13 13:45:17 UTC) #5
rsc
Thanks very much for doing this. http://codereview.appspot.com/5262041/diff/18001/src/pkg/crypto/tls/common.go File src/pkg/crypto/tls/common.go (right): http://codereview.appspot.com/5262041/diff/18001/src/pkg/crypto/tls/common.go#newcode157 src/pkg/crypto/tls/common.go:157: // SkipVerification controls ...
8 years, 5 months ago (2011-10-13 15:14:35 UTC) #6
mkrautz
Thanks, I'll fix these. http://codereview.appspot.com/5262041/diff/18001/src/pkg/crypto/tls/handshake_client.go File src/pkg/crypto/tls/handshake_client.go (right): http://codereview.appspot.com/5262041/diff/18001/src/pkg/crypto/tls/handshake_client.go#newcode100 src/pkg/crypto/tls/handshake_client.go:100: // If we don't have ...
8 years, 5 months ago (2011-10-13 15:37:50 UTC) #7
rsc
> I kept it around mainly to allow systems that use root_stub.go to still > ...
8 years, 5 months ago (2011-10-13 15:50:17 UTC) #8
mkrautz
Hello adg@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
8 years, 5 months ago (2011-10-13 16:55:35 UTC) #9
rsc
LGTM http://codereview.appspot.com/5262041/diff/28001/src/pkg/crypto/tls/handshake_client.go File src/pkg/crypto/tls/handshake_client.go (right): http://codereview.appspot.com/5262041/diff/28001/src/pkg/crypto/tls/handshake_client.go#newcode100 src/pkg/crypto/tls/handshake_client.go:100: if c.config.InsecureSkipVerify == false { if !c.config.InsecureSkipVerify {
8 years, 5 months ago (2011-10-13 17:17:59 UTC) #10
mkrautz
Hello adg@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
8 years, 5 months ago (2011-10-13 17:22:14 UTC) #11
rsc
LGTM Thanks again.
8 years, 5 months ago (2011-10-13 17:27:00 UTC) #12
rsc
8 years, 5 months ago (2011-10-13 17:59:19 UTC) #13
*** Submitted as http://code.google.com/p/go/source/detail?r=31f70d4380cd ***

crypto/tls: fetch root certificates using Mac OS API

Fixes issue 1009.

R=adg, rsc
CC=golang-dev
http://codereview.appspot.com/5262041

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b