Support revision-less charm URLs for GUI.

Support revision-less charm URLs for GUI.

Existing code to find the 'qualified url' for charms was refactored and
re-used by the GUIEnv deploy method.

https://code.launchpad.net/~bac/juju-deployer/bug-1277696/+merge/206008

(do not edit description out of merge proposal)

[bac, 2014-02-12 17:07:24]

Please take a look.

[frankban, 2014-02-12 18:28:37]

Thanks for this nice branch Brad, LGTM.
I'll just add some comments waiting for Kapil to be back and available.
Thank you!

https://codereview.appspot.com/52600045/diff/1/.lbox.check
File .lbox.check (right):

https://codereview.appspot.com/52600045/diff/1/.lbox.check#newcode3
.lbox.check:3: /usr/bin/nosetests -s --verbosity=2 deployer
I usally test the deployer in a virtualenv. With this change I would need nose
to be globally installed in order to propose a deployer branch. <shrug>

https://codereview.appspot.com/52600045/diff/1/deployer/tests/test_constraint...
File deployer/tests/test_constraints.py (right):

https://codereview.appspot.com/52600045/diff/1/deployer/tests/test_constraint...
deployer/tests/test_constraints.py:110: parse_constraints(value)
Thank you.

https://codereview.appspot.com/52600045/diff/1/deployer/tests/test_guienv.py
File deployer/tests/test_guienv.py (right):

https://codereview.appspot.com/52600045/diff/1/deployer/tests/test_guienv.py#...
deployer/tests/test_guienv.py:57: # The environment uses the API to deploy
charms.
This comment does not reflect the goal of the test.

https://codereview.appspot.com/52600045/diff/1/deployer/tests/test_guienv.py#...
deployer/tests/test_guienv.py:62: constraints = {'cpu-cores': '4', 'mem': '5G',
'root-disk': '2G'}
I'd be inclined to remove constraints from this test.

https://codereview.appspot.com/52600045/diff/1/deployer/tests/test_guienv.py#...
deployer/tests/test_guienv.py:65: def mocked_gqu(url):
s/mocked_gqu/mock_get_qualified_charm_url/?

https://codereview.appspot.com/52600045/diff/1/deployer/tests/test_guienv.py#...
deployer/tests/test_guienv.py:80: 'myservice', 'cs:precise/service-98',
config=config,
Cool.

https://codereview.appspot.com/52600045/diff/1/deployer/utils.py
File deployer/utils.py (right):

https://codereview.appspot.com/52600045/diff/1/deployer/utils.py#newcode325
deployer/utils.py:325: # Local import to avoid circular reference
We could instead define STORE_URL and then import it in charms.py.
<shrug>

https://codereview.appspot.com/52600045/diff/1/deployer/utils.py#newcode330
deployer/utils.py:330: fh = urllib.urlopen(info_url)
I know this is pre-existing, but the fact we use urlopen without checking
exceptions makes me a bit nervous. If you think it's worth the effort, given
this code path is used by our GUIEnvironment, it would be nice if we re-raise
possible errors with a better, more human friendly message. This can be done
here or in gui.py.

[bac, 2014-02-12 21:03:34]

Please take a look.

https://codereview.appspot.com/52600045/diff/1/.lbox.check
File .lbox.check (right):

https://codereview.appspot.com/52600045/diff/1/.lbox.check#newcode3
.lbox.check:3: /usr/bin/nosetests -s --verbosity=2 deployer
Dang.  I'll just back this out or run the tests differently.  Don't want to make
too many infrastructure changes in this branch.

---

Changed to use setup.py to run them.  Good enough for lbox.check I say.

https://codereview.appspot.com/52600045/diff/1/deployer/tests/test_guienv.py
File deployer/tests/test_guienv.py (right):

https://codereview.appspot.com/52600045/diff/1/deployer/tests/test_guienv.py#...
deployer/tests/test_guienv.py:57: # The environment uses the API to deploy
charms.
On 2014/02/12 18:28:37, frankban wrote:
> This comment does not reflect the goal of the test.

Done.

https://codereview.appspot.com/52600045/diff/1/deployer/tests/test_guienv.py#...
deployer/tests/test_guienv.py:62: constraints = {'cpu-cores': '4', 'mem': '5G',
'root-disk': '2G'}
On 2014/02/12 18:28:37, frankban wrote:
> I'd be inclined to remove constraints from this test.

Done.

https://codereview.appspot.com/52600045/diff/1/deployer/tests/test_guienv.py#...
deployer/tests/test_guienv.py:65: def mocked_gqu(url):
On 2014/02/12 18:28:37, frankban wrote:
> s/mocked_gqu/mock_get_qualified_charm_url/?

Done.

https://codereview.appspot.com/52600045/diff/1/deployer/utils.py
File deployer/utils.py (right):

https://codereview.appspot.com/52600045/diff/1/deployer/utils.py#newcode325
deployer/utils.py:325: # Local import to avoid circular reference
On 2014/02/12 18:28:37, frankban wrote:
> We could instead define STORE_URL and then import it in charms.py.
> <shrug>

Done.