LGTM - gri On Wed, Oct 12, 2011 at 11:43 AM, <r@golang.org> wrote: > Reviewers: ...
13 years, 6 months ago
(2011-10-12 18:46:20 UTC)
#2
LGTM
- gri
On Wed, Oct 12, 2011 at 11:43 AM, <r@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> netchan: move to old/netchan
> Part of Go version 1 rearrangement.
> No gofix, since the new name is not in Go 1.
>
> Please review this at http://codereview.appspot.com/5245055/
>
> Affected files:
> M src/pkg/Makefile
> M src/pkg/old/netchan/Makefile
> M src/pkg/old/netchan/common.go
> M src/pkg/old/netchan/export.go
> M src/pkg/old/netchan/import.go
> M src/pkg/old/netchan/netchan_test.go
>
>
> Index: src/pkg/Makefile
> ===================================================================
> --- a/src/pkg/Makefile
> +++ b/src/pkg/Makefile
> @@ -130,7 +130,7 @@
> net\
> net/dict\
> net/textproto\
> - netchan\
> + old/netchan\
> old/regexp\
> old/template\
> os\
> Index: src/pkg/old/netchan/Makefile
> ===================================================================
> rename from src/pkg/netchan/Makefile
> rename to src/pkg/old/netchan/Makefile
> --- a/src/pkg/netchan/Makefile
> +++ b/src/pkg/old/netchan/Makefile
> @@ -2,12 +2,12 @@
> # Use of this source code is governed by a BSD-style
> # license that can be found in the LICENSE file.
>
> -include ../../Make.inc
> +include ../../../Make.inc
>
> -TARG=netchan
> +TARG=old/netchan
> GOFILES=\
> common.go\
> export.go\
> import.go\
>
> -include ../../Make.pkg
> +include ../../../Make.pkg
> Index: src/pkg/old/netchan/common.go
> ===================================================================
> rename from src/pkg/netchan/common.go
> rename to src/pkg/old/netchan/common.go
> Index: src/pkg/old/netchan/export.go
> ===================================================================
> rename from src/pkg/netchan/export.go
> rename to src/pkg/old/netchan/export.go
> Index: src/pkg/old/netchan/import.go
> ===================================================================
> rename from src/pkg/netchan/import.go
> rename to src/pkg/old/netchan/import.go
> Index: src/pkg/old/netchan/netchan_test.go
> ===================================================================
> rename from src/pkg/netchan/netchan_test.go
> rename to src/pkg/old/netchan/netchan_test.go
>
>
>
Issue 5245055: code review 5245055: netchan: move to old/netchan
(Closed)
Created 13 years, 6 months ago by r
Modified 13 years, 6 months ago
Reviewers:
Base URL:
Comments: 0