Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(42)

Issue 5244045: Makeify the website build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by Julien Rioux
Modified:
7 years, 9 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Makeify the website build. Properly track dependencies, allow for parallel build, and rebuild only what needs to be updated.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -94 lines) Patch
M make/website.make View 2 chunks +166 lines, -94 lines 2 comments Download

Messages

Total messages: 1
Graham Percival (old account)
7 years, 11 months ago (2011-10-09 16:03:08 UTC) #1
LGTM, thanks so much for cleaning this up!

http://codereview.appspot.com/5244045/diff/1/make/website.make
File make/website.make (right):

http://codereview.appspot.com/5244045/diff/1/make/website.make#newcode73
make/website.make:73: CREATE_VERSION=python
$(script-dir)/create-version-itexi.py
whoops, we're inconsistent in whether we use python or $(PYTHON).  Let's leave
it there for now, but it's something for future consideration

http://codereview.appspot.com/5244045/diff/1/make/website.make#newcode106
make/website.make:106: bib-files = $(OUT)/others-did.itexi $(OUT)/we-wrote.itexi
we'll be able to remove the bib stuff once the dev/website-build material has
been added.  I'll have to re-do that stuff, but it'll be easy with the new
website.make.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b