Issue 5236041: code review 5236041: godoc: user scanner instead of go/scanner for ebnf proc...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5236041: code review 5236041: godoc: user scanner instead of go/scanner for ebnf proc... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by gri

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

godoc: use scanner instead of go/scanner for ebnf processing of spec Also: Fewer calls to flush for faster processing (once per identifier or error instead of once per token).

Patch Set 1 #

Patch Set 2 : diff -r 957ea35c7f91 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 957ea35c7f91 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 957ea35c7f91 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r f2c56d5fa9ef https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r f2c56d5fa9ef https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -78 lines)			Patch
	M	src/cmd/godoc/godoc.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/cmd/godoc/spec.go	View	1 2 3 4 5	5 chunks	+58 lines, -77 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-10-07 04:04:01 UTC) #1

gri

13 years, 5 months ago (2011-10-07 04:46:10 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=48caa9c4edf8 ***

godoc: use scanner instead of go/scanner for ebnf processing of spec

Also: Fewer calls to flush for faster processing (once per identifier
or error instead of once per token).

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5236041

Expand All Messages | Collapse All Messages