Issue 5235041: code review 5235041: dashboard: include last 100 lines in build failure mail

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5235041: code review 5235041: dashboard: include last 100 lines in build failure mail (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by adg

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, rsc, iant2, rh

Visibility:
Public.

Description

dashboard: include last 100 lines in build failure mail

Patch Set 1 #

Patch Set 2 : diff -r 594495a1b5ec https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 62c997927b20 https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	misc/dashboard/godashboard/fail-notify.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	misc/dashboard/godashboard/gobuild.py	View	1	4 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2011-10-07 02:37:02 UTC) #1

iant2

FYI Russ Cox <rsc@golang.org> writes: > s/tail -n 100/tail -100/ May not be a good ...

13 years, 5 months ago (2011-10-07 04:00:39 UTC) #3

rsc

>> s/tail -n 100/tail -100/ > > May not be a good idea. tail -100 ...

13 years, 5 months ago (2011-10-07 04:04:35 UTC) #4

On 2011/10/07 03:14:58, rsc wrote: > LGTM > > fixes some issue. > > s/tail ...

13 years, 5 months ago (2011-10-07 04:35:31 UTC) #5

adg

13 years, 5 months ago (2011-10-08 19:50:29 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=65d7e79f0fc7 ***

dashboard: include last 100 lines in build failure mail

R=golang-dev, rsc, iant, robert.hencke
CC=golang-dev
http://codereview.appspot.com/5235041

Expand All Messages | Collapse All Messages