code review 52140043: misc: bash & zsh completion fixes.

misc: bash & zsh completion fixes.

Update bash and zsh completion to reflect current
commands.

[john.gosset, 2014-01-14 16:52:41]

Hello golang-dev@googlegroups.com (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[gobot, 2014-01-14 16:56:29]

Replacing golang-dev with golang-codereviews.

To the author of this CL: 

If you are using 'hg mail -r golang-dev' to mail the CL, use simply 'hg mail'
instead.

If you did not name golang-dev explicitly and it was still added to the CL,
it means your working copy of the repo has a stale codereview.cfg
(or lib/codereview/codereview.cfg).
Please run 'hg sync' to update your client to the most recent codereview.cfg.
If the most recent codereview.cfg has defaultcc set to golang-dev instead of
golang-codereviews, please send a CL correcting it.

Thanks very much.

[dave_cheney.net, 2014-02-05 02:51:57]

On 2014/01/14 16:56:29, gobot wrote:
> Replacing golang-dev with golang-codereviews.
> 
> To the author of this CL: 
> 
> If you are using 'hg mail -r golang-dev' to mail the CL, use simply 'hg mail'
> instead.
> 
> If you did not name golang-dev explicitly and it was still added to the CL,
> it means your working copy of the repo has a stale codereview.cfg
> (or lib/codereview/codereview.cfg).
> Please run 'hg sync' to update your client to the most recent codereview.cfg.
> If the most recent codereview.cfg has defaultcc set to golang-dev instead of
> golang-codereviews, please send a CL correcting it.
> 
> Thanks very much.

Thank you. This looks good to me. 

I do not see your name in the CONTRIBUTORS file, have you filled out a CLA ?

[gobot, 2014-02-05 02:52:25]

R=dave@cheney.net (assigned by dave@cheney.net)

[dave_cheney.net, 2014-02-09 23:54:49]

ping

[dave_cheney.net, 2014-02-23 23:56:24]

ping

[john.gosset, 2014-02-24 01:44:13]

Hello,

Are you still waiting on me for anything? If so, please let me know.

Best,
John


On Sun, Feb 23, 2014 at 6:56 PM, <dave@cheney.net> wrote:

> ping
>
> https://codereview.appspot.com/52140043/
>

[dave_cheney.net, 2014-02-24 01:45:51]

Have you filed a CLA ?

[john.gosset, 2014-02-24 01:48:22]

Yes, I did that electronically [here] on Feb. 4th 2014.

[here]: https://developers.google.com/open-source/cla/individual


On Sun, Feb 23, 2014 at 8:45 PM, <dave@cheney.net> wrote:

> Have you filed a CLA ?
>
> https://codereview.appspot.com/52140043/
>

[minux1, 2014-02-24 01:56:13]

both scripts still need some more work to be completely
updated.

https://codereview.appspot.com/52140043/diff/40001/misc/bash/go
File misc/bash/go (right):

https://codereview.appspot.com/52140043/diff/40001/misc/bash/go#newcode191
misc/bash/go:191: 'ebnflint') # TODO: Implement something.
remove

https://codereview.appspot.com/52140043/diff/40001/misc/bash/go#newcode197
misc/bash/go:197: 'gotype') # TODO: Implement something.
remove

https://codereview.appspot.com/52140043/diff/40001/misc/bash/go#newcode209
misc/bash/go:209: 'prof') # TODO: Implement something.
may as well remove as prof won't be in release.

https://codereview.appspot.com/52140043/diff/40001/misc/zsh/go
File misc/zsh/go (right):

https://codereview.appspot.com/52140043/diff/40001/misc/zsh/go#newcode103
misc/zsh/go:103: "-memprofilerate[set heap profiling rate]:number" \
-cover?

[rsc, 2014-03-05 19:57:13]

R=minux.ma@gmail.com

john.gosset, if you'd like this to get in please make the revisions suggested
soon.

[minux1, 2014-03-07 02:30:34]

john.gosset, please let me know if you don't have time to finish
this CL. I can take it over in that case. Thank you!

On Wed, Mar 5, 2014 at 2:57 PM, <rsc@golang.org> wrote:

> john.gosset, if you'd like this to get in please make the revisions
> suggested soon.
>

[rsc, 2014-04-17 03:14:05]

R=close

minux if the changes are sufficiently tiny (<10 lines) feel free to create
another CL for 1.3. otherwise wait for 1.4. thanks.