Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(764)

Issue 5209045: code review 5209045: template: add method Delims to allow alternate action d... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by r
Modified:
10 years, 3 months ago
Reviewers:
CC:
golang-dev, rsc, dsymonds
Visibility:
Public.

Description

template: add method Delims to allow alternate action delimiters.

Patch Set 1 #

Total comments: 6

Patch Set 2 : diff -r b76a554937cb https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -38 lines) Patch
M src/pkg/template/exec_test.go View 3 chunks +48 lines, -10 lines 0 comments Download
M src/pkg/template/parse.go View 4 chunks +14 lines, -2 lines 0 comments Download
M src/pkg/template/parse/lex.go View 6 chunks +26 lines, -16 lines 0 comments Download
M src/pkg/template/parse/lex_test.go View 2 chunks +37 lines, -3 lines 0 comments Download
M src/pkg/template/parse/parse.go View 1 chunk +4 lines, -3 lines 0 comments Download
M src/pkg/template/parse/parse_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/template/parse/set.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/template/set.go View 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 5
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 3 months ago (2011-10-06 20:19:37 UTC) #1
rsc
LGTM
10 years, 3 months ago (2011-10-06 20:25:53 UTC) #2
dsymonds
http://codereview.appspot.com/5209045/diff/1/src/pkg/template/exec_test.go File src/pkg/template/exec_test.go (right): http://codereview.appspot.com/5209045/diff/1/src/pkg/template/exec_test.go#newcode496 src/pkg/template/exec_test.go:496: var delimPairs = []string{ I would have gone for ...
10 years, 3 months ago (2011-10-06 20:30:27 UTC) #3
r
*** Submitted as http://code.google.com/p/go/source/detail?r=a71b3310c793 *** template: add method Delims to allow alternate action delimiters. R=golang-dev, ...
10 years, 3 months ago (2011-10-06 20:30:53 UTC) #4
rsc
10 years, 3 months ago (2011-10-06 20:31:16 UTC) #5
On Thu, Oct 6, 2011 at 16:30,  <dsymonds@golang.org> wrote:
> Can you add a test where the delimiters are bigger than two bytes?

 "(日)", "(本)", // peculiar
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b