code review 5209045: template: add method Delims to allow alternate action d...

template: add method Delims to allow alternate action delimiters.

[r, 2011-10-06 20:19:37]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-10-06 20:25:53]

LGTM

[dsymonds, 2011-10-06 20:30:27]

http://codereview.appspot.com/5209045/diff/1/src/pkg/template/exec_test.go
File src/pkg/template/exec_test.go (right):

http://codereview.appspot.com/5209045/diff/1/src/pkg/template/exec_test.go#ne...
src/pkg/template/exec_test.go:496: var delimPairs = []string{
I would have gone for a [][2]string and save some effort in the test, but this
is fine.

http://codereview.appspot.com/5209045/diff/1/src/pkg/template/exec_test.go#ne...
src/pkg/template/exec_test.go:501: "(日)", "(本)", // peculiar
indeed

http://codereview.appspot.com/5209045/diff/1/src/pkg/template/exec_test.go#ne...
src/pkg/template/exec_test.go:502: }
Can you add a test where the delimiters are bigger than two bytes?

http://codereview.appspot.com/5209045/diff/1/src/pkg/template/exec_test.go#ne...
src/pkg/template/exec_test.go:530: }
A way to get delimiters to show up is
  {{"{{"}}
or similar. Can you check that that idiom works correctly?

http://codereview.appspot.com/5209045/diff/1/src/pkg/template/parse/lex.go
File src/pkg/template/parse/lex.go (right):

http://codereview.appspot.com/5209045/diff/1/src/pkg/template/parse/lex.go#ne...
src/pkg/template/parse/lex.go:233: leftComment  = "{{/*"
oh. So changing the delimiters won't change what you use for comments? That
seems a little confusing.

http://codereview.appspot.com/5209045/diff/1/src/pkg/template/parse/lex_test.go
File src/pkg/template/parse/lex_test.go (right):

http://codereview.appspot.com/5209045/diff/1/src/pkg/template/parse/lex_test....
src/pkg/template/parse/lex_test.go:225: // Some easy cases from above, but with
delimiters are $$ and @@
bad grammar (s/are //?)

[r, 2011-10-06 20:30:53]

*** Submitted as http://code.google.com/p/go/source/detail?r=a71b3310c793 ***

template: add method Delims to allow alternate action delimiters.

R=golang-dev, rsc, dsymonds
CC=golang-dev
http://codereview.appspot.com/5209045

[rsc, 2011-10-06 20:31:16]

On Thu, Oct 6, 2011 at 16:30,  <dsymonds@golang.org> wrote:
> Can you add a test where the delimiters are bigger than two bytes?

 "(日)", "(本)", // peculiar