Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 5206046: code review 5206046: go/ast: don't remove function bodies when filtering exports (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by gri
Modified:
13 years, 5 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

go/ast: don't remove function bodies when filtering exports This is a semantic but no API change. It is a cleaner implementation of pure filtering. Applications that need function bodies stripped can easily do this them- selves.

Patch Set 1 #

Patch Set 2 : diff -r a71b3310c793 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a71b3310c793 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a71b3310c793 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r a71b3310c793 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r b2a2889cfdf8 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/pkg/go/ast/filter.go View 1 2 3 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 6
gri
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 5 months ago (2011-10-06 21:54:44 UTC) #1
rsc
Needs a gofix. Also we need to stop changing this API soon. Russ
13 years, 5 months ago (2011-10-06 21:59:04 UTC) #2
rsc
I see the godoc CL now. Another problem is that ", true" at the call ...
13 years, 5 months ago (2011-10-06 22:02:26 UTC) #3
gri
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 5 months ago (2011-10-06 22:40:48 UTC) #4
rsc
LGTM Much nicer, thanks. I am assuming that you are going to compensate for this ...
13 years, 5 months ago (2011-10-06 22:54:25 UTC) #5
gri
13 years, 5 months ago (2011-10-06 23:07:59 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=d8359b940dee ***

go/ast: don't remove function bodies when filtering exports

This is a semantic but no API change. It is a cleaner
implementation of pure filtering. Applications that
need function bodies stripped can easily do this them-
selves.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5206046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b