code review 5206046: go/ast: don't remove function bodies when filtering exports

go/ast: don't remove function bodies when filtering exports

This is a semantic but no API change. It is a cleaner
implementation of pure filtering. Applications that
need function bodies stripped can easily do this them-
selves.

[gri, 2011-10-06 21:54:44]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-10-06 21:59:04]

Needs a gofix.  Also we need to stop changing this API soon.

Russ

[rsc, 2011-10-06 22:02:26]

I see the godoc CL now.
Another problem is that ", true" at the call site is opaque.
Can we do something more general here (like an options struct)
so that more fields can be added later without breaking existing
code?  That would also help at the call sites.

Russ

[gri, 2011-10-06 22:40:48]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-10-06 22:54:25]

LGTM

Much nicer, thanks.

I am assuming that you are going to compensate for this
change in godoc: if so, you probably want to wait to submit
until Andrew finishes tagging the weekly snapshot, so that
we don't have just one of the two changes in the snapshot.

[gri, 2011-10-06 23:07:59]

*** Submitted as http://code.google.com/p/go/source/detail?r=d8359b940dee ***

go/ast: don't remove function bodies when filtering exports

This is a semantic but no API change. It is a cleaner
implementation of pure filtering. Applications that
need function bodies stripped can easily do this them-
selves.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5206046