Issue 5188042: code review 5188042: ebnf, ebnflint: move under exp

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5188042: code review 5188042: ebnf, ebnflint: move under exp (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by gri

Modified:
13 years, 5 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

ebnf, ebnflint: move under exp pkg/ebnf -> pkg/exp/ebnf cmd/ebnflint -> pkg/exp/ebnflint

Patch Set 1 #

Patch Set 2 : diff -r dc083cef8574 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r dc083cef8574 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 5944fd5ec54a https://go.googlecode.com/hg/ #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
M	src/cmd/Makefile	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/Makefile	View	1 2 3	5 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/exp/ebnf/Makefile	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/exp/ebnf/ebnf.go	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	src/pkg/exp/ebnf/ebnf_test.go	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	src/pkg/exp/ebnf/parser.go	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	src/pkg/exp/ebnflint/Makefile	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/exp/ebnflint/doc.go	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	src/pkg/exp/ebnflint/ebnflint.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/run.bash	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 6 months ago (2011-10-05 18:11:26 UTC) #1

gri

13 years, 5 months ago (2011-10-12 00:43:15 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=dab0a510b7bb ***

ebnf, ebnflint: move under exp

pkg/ebnf -> pkg/exp/ebnf
cmd/ebnflint -> pkg/exp/ebnflint

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5188042

Expand All Messages | Collapse All Messages