Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(681)

Issue 51650043: Properly proof bundles with inheritance.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by bac
Modified:
10 years, 3 months ago
Reviewers:
rharding, mp+201512
Visibility:
Public.

Description

Properly proof bundles with inheritance. - Use the existing get_flattened_deployment to realize the inheritance. - Update to new version of charm-tools. - Specify version for charmworldlib rather than grabbing the latest from pypi. - Add work-around to forking charm-tools to allow proofing on localhost during ingest. QA: In one terminal: % make run In another: % bin/ingest-queued --prefix=~bac Ensure that ~bac/charms/bundle/complicated/bundle ingests A-OK. https://code.launchpad.net/~bac/charmworld/1263112/+merge/201512 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Properly proof bundles with inheritance. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -66 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M charmworld/jobs/ingest.py View 3 chunks +30 lines, -6 lines 0 comments Download
M charmworld/jobs/tests/test_ingest.py View 1 chunk +6 lines, -6 lines 0 comments Download
M charmworld/jobs/tests/test_proof.py View 1 chunk +24 lines, -25 lines 0 comments Download
M charmworld/lib/proof.py View 1 chunk +3 lines, -0 lines 0 comments Download
M charmworld/lib/tests/test_proof.py View 2 chunks +22 lines, -1 line 0 comments Download
M charmworld/views/api/proof.py View 1 5 chunks +11 lines, -2 lines 0 comments Download
M charmworld/views/tests/test_proof.py View 1 3 chunks +86 lines, -25 lines 0 comments Download
M requirements.txt View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
bac
Please take a look.
10 years, 3 months ago (2014-01-13 21:36:22 UTC) #1
rharding
Generally ok. I don't see any tests around the inheritance feature? https://codereview.appspot.com/51650043/diff/1/charmworld/views/api/proof.py File charmworld/views/api/proof.py (right): ...
10 years, 3 months ago (2014-01-14 13:58:36 UTC) #2
bac
Thanks for the review. https://codereview.appspot.com/51650043/diff/1/charmworld/jobs/tests/test_proof.py File charmworld/jobs/tests/test_proof.py (right): https://codereview.appspot.com/51650043/diff/1/charmworld/jobs/tests/test_proof.py#newcode31 charmworld/jobs/tests/test_proof.py:31: update_proof_data(charm, getLogger('charm.proof')) These recharacterizations are ...
10 years, 3 months ago (2014-01-14 14:01:14 UTC) #3
bac
Please take a look.
10 years, 3 months ago (2014-01-14 19:27:48 UTC) #4
rharding
10 years, 3 months ago (2014-01-14 19:36:52 UTC) #5
LGTM thanks for the updated test case.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b