Issue 5156042: code review 5156042: runtime: fix windows build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5156042: code review 5156042: runtime: fix windows build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by hector

Modified:
13 years, 6 months ago

Reviewers:

CC:
golang-dev, r, dsymonds, rsc, r2

Visibility:
Public.

Description

runtime: fix windows build Add osyield and usleep as required by recent GC changes.

Patch Set 1 #

Patch Set 2 : diff -r 99142734db76 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 99142734db76 https://go.googlecode.com/hg/ #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -0 lines)			Patch
M	src/pkg/runtime/windows/386/defs.h	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/windows/amd64/defs.h	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/windows/defs.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/runtime/windows/thread.c	View	1	7 chunks	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

hector

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 6 months ago (2011-09-30 18:27:03 UTC) #1

hector

On 2011/09/30 18:28:00, dsymonds wrote: > Please make the CL description a bit more descriptive. ...

13 years, 6 months ago (2011-09-30 18:30:09 UTC) #4

on it On Sep 30, 2011, at 11:30 AM, Russ Cox wrote: > LGTM > ...

13 years, 6 months ago (2011-09-30 18:32:13 UTC) #6

13 years, 6 months ago (2011-09-30 18:33:17 UTC) #8

*** Submitted as http://code.google.com/p/go/source/detail?r=f4485e8acf87 ***

runtime: fix windows build

Add osyield and usleep as required by recent GC changes.

R=golang-dev, r, dsymonds, rsc, r
CC=golang-dev
http://codereview.appspot.com/5156042

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages