src/cmd/gc/builtin.c.boot - Issue 5149045: code review 5149045: runtime: append([]byte, string...)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/cmd/gc/builtin.c.boot

Issue 5149045: code review 5149045: runtime: append([]byte, string...) (Closed)

Patch Set: diff -r 2904af657e75 https://go.googlecode.com/hg/ Created 13 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/cmd/gc/builtin.c.boot

===================================================================

--- a/src/cmd/gc/builtin.c.boot

+++ b/src/cmd/gc/builtin.c.boot

@@ -25,6 +25,7 @@

"func @\"\".concatstring ()\n"

"func @\"\".append ()\n"

"func @\"\".appendslice (typ *uint8, x any, y []any) any\n"

+ "func @\"\".appendstr (typ *uint8, x []uint8, y string) []uint8\n"

"func @\"\".cmpstring (? string, ? string) int\n"

"func @\"\".slicestring (? string, ? int, ? int) string\n"

"func @\"\".slicestring1 (? string, ? int) string\n"

« no previous file with comments | « doc/go_spec.html ('k') | src/cmd/gc/runtime.go » ('j') | no next file with comments »